From owner-dev-commits-ports-all@freebsd.org Tue Apr 20 03:24:31 2021 Return-Path: Delivered-To: dev-commits-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0C15B5E23D2; Tue, 20 Apr 2021 03:24:31 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FPTZ63KQYz3hN4; Tue, 20 Apr 2021 03:24:29 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.66.148.124]) by shaw.ca with ESMTPA id YgzxlTn89HmS3YgzzlxB3K; Mon, 19 Apr 2021 21:24:28 -0600 X-Authority-Analysis: v=2.4 cv=MaypB7zf c=1 sm=1 tr=0 ts=607e496c a=Cwc3rblV8FOMdVN/wOAqyQ==:117 a=Cwc3rblV8FOMdVN/wOAqyQ==:17 a=kj9zAlcOel0A:10 a=3YhXtTcJ-WEA:10 a=6I5d2MoRAAAA:8 a=mExc1W1qAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=lTRNZ33RUglDMqUCklYA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=vGwSRmdCM4kNLdo7YWN-:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id A447B756; Mon, 19 Apr 2021 20:24:24 -0700 (PDT) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.16.1/8.16.1) with ESMTP id 13K3OOwj010751; Mon, 19 Apr 2021 20:24:24 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <202104200324.13K3OOwj010751@slippy.cwsent.com> X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Pedro Giffuni cc: Dmitry Sivachenko , Yuri , ports-committers , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: d3ba089a5212 - main - Update to version 2.2.13. In-reply-to: <59a11a3f-3a47-176b-a566-a154709a4a69@FreeBSD.org> References: <202104192213.13JMDlRd039737@gitrepo.freebsd.org> <59a11a3f-3a47-176b-a566-a154709a4a69@FreeBSD.org> Comments: In-reply-to Pedro Giffuni message dated "Mon, 19 Apr 2021 21:13:28 -0500." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 19 Apr 2021 20:24:24 -0700 X-CMAE-Envelope: MS4xfI6BACiHOnNh+5SMA251KduBlcgNe9gh+PvflfGjB5NhXRy92D0LHdM1/9DF1ATFOGlQVouCdcGsiZrW8yp8+rUdH0rqkMoiVMRPpv+aKTZEgtpJoEJm ZVGtUnFKoATH4w49S4JUaqTCkx9flFMJKjeQRORZsQiYxXwIdElWJYwpUOlqYoq1GbcX3C8Dl+glvvzy9Tpley14Yz7J2uDDONgvUBsDbJYUxdZk/Ql7YKWs XgSlEkmy8t/D8ZstRZsxPTOBTNdaEpv17uuLe2oAico+Lh1r9apWIBrs4pls/G9oapMuEfuPAmjUGFQbMTuzg/VLvMLDMU1RPMY45WMEuSqx//8HtZDaP+83 M4m+369jc2aOzW7WOYnK3cpSzxWJT8/cxS1xrXK43Ixp+fyX50E= X-Rspamd-Queue-Id: 4FPTZ63KQYz3hN4 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Apr 2021 03:24:31 -0000 In message <59a11a3f-3a47-176b-a566-a154709a4a69@FreeBSD.org>, Pedro Giffuni wr ites: > On 19/04/2021 17:24, Dmitry Sivachenko wrote: > > > >> On 20 Apr 2021, at 01:17, Yuri wrote: > >> > >> On 4/19/21 3:13 PM, Dmitry Sivachenko wrote: > >>> Update to version 2.2.13. > >> > >> Why didn't you mention in the commit message what port was updated? > >> net/haproxy is one of thousands of ports and having a message like this do > esn't help to understand what the change is. > >> > > Hello, > > > > what do you mean 'what port was updated'? It is clean from the commit log > that it is net/haproxy that was updated, only two files changed: > > Update to version 2.2.13. > > It is not a all "clean" if you do: > > git log --oneline This is a systemic problem that probably needs to be addressed sooner than later. An aid like a .gitmessage might help. To help me remember I used this: # component (like category/port or bin/cat): Title line goes here # A paragraph or more to discuss the change. PR: Submitted by: Reported by: Reviewed by: Approved by: Obtained from: MFC after: MFH: Relnotes: Security: Sponsored by: Differential Revision: #--This line, and those below, will be ignored-- # Description of fields to fill in above: 76 columns --| # PR: If and which Problem Report is related. # Submitted by: If someone else sent in the change. # Reported by: If someone else reported the issue. # Reviewed by: If someone else reviewed your modification. # Tested by: If someone else tested the change. # Approved by: If you needed approval for this commit. # Obtained from: If the change is from a third party. # MFC after: N [day[s]|week[s]|month[s]]. Request a reminder email. # MFH: Ports tree branch name. Request approval for merge. # Relnotes: Set to 'yes' for mention in release notes. # Security: Vulnerability reference (one per line) or description. # Sponsored by: If the change was sponsored by an organization. # Differential Revision: https://reviews.freebsd.org/D### (*full* phabric URL needed). # Empty fields above will be automatically removed. Replacing the first two comments with a title line and a short paragraph, filling in the fields as needed, discarding the rest. This, https://chris.beams.io/posts/git-commit/, is a good read. Old habits die hard. Someone reached out to me in January but the .gitmessage template helped me a lot. Unlearning old habits is harder than learning new ones. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org The need of the many outweighs the greed of the few.