From owner-freebsd-bugs@FreeBSD.ORG  Mon May  2 14:10:10 2011
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B77E0106567A
	for <freebsd-bugs@hub.freebsd.org>;
	Mon,  2 May 2011 14:10:10 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 79EFD8FC19
	for <freebsd-bugs@hub.freebsd.org>;
	Mon,  2 May 2011 14:10:10 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p42EAAhW034190
	for <freebsd-bugs@freefall.freebsd.org>; Mon, 2 May 2011 14:10:10 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p42EAASg034188;
	Mon, 2 May 2011 14:10:10 GMT (envelope-from gnats)
Resent-Date: Mon, 2 May 2011 14:10:10 GMT
Resent-Message-Id: <201105021410.p42EAASg034188@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Adrian Chadd <adrian@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 87E27106564A
	for <freebsd-gnats-submit@FreeBSD.org>;
	Mon,  2 May 2011 14:03:08 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 774DB8FC1B
	for <freebsd-gnats-submit@FreeBSD.org>;
	Mon,  2 May 2011 14:03:08 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p42E38fu026336
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 2 May 2011 14:03:08 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p42E386p026327;
	Mon, 2 May 2011 14:03:08 GMT (envelope-from nobody)
Message-Id: <201105021403.p42E386p026327@red.freebsd.org>
Date: Mon, 2 May 2011 14:03:08 GMT
From: Adrian Chadd <adrian@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: kern/156765: [ath] Merlin fast-clock check isn't correct
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 02 May 2011 14:10:10 -0000


>Number:         156765
>Category:       kern
>Synopsis:       [ath] Merlin fast-clock check isn't correct
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon May 02 14:10:10 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     Adrian Chadd
>Release:        -HEAD
>Organization:
>Environment:
n/a
>Description:
The HAL Merlin fast clock check simply checks the EEPROM flag.

The ath9k check is (hw.c):

               if (AR_SREV_9280_20(ah) &&
                    ((ah->eep_ops->get_eeprom(ah, EEP_MINOR_REV) <=
                      AR5416_EEP_MINOR_VER_16) ||
                     ah->eep_ops->get_eeprom(ah, EEP_FSTCLK_5G)))
                        pCap->hw_caps |= ATH9K_HW_CAP_FASTCLOCK;

Go through the code, add a capability flag for fastclock, use that instead of the #define, and make sure that capability is properly set at Merlin probe/attach time.

>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
>Unformatted: