Date: Wed, 28 Sep 2016 09:38:19 -0500 From: John Marino <freebsd.contact@marino.st> To: Mathieu Arnold <mat@FreeBSD.org>, marino@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r422874 - in head: devel/efl net-mgmt/nsca-ng net-mgmt/zabbix3-server net-mgmt/zabbix32-server www/tomcat-native Message-ID: <b809192c-1a26-075c-72ff-94fcc94357d1@marino.st> In-Reply-To: <662bee21-3341-df4f-ffce-e721a9824519@FreeBSD.org> References: <201609281347.u8SDls64072549@repo.freebsd.org> <2930934c-272b-50bd-8c7f-d02a7761f92f@marino.st> <662bee21-3341-df4f-ffce-e721a9824519@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9/28/2016 09:35, Mathieu Arnold wrote: > Le 28/09/2016 à 16:31, John Marino a écrit : >> On 9/28/2016 08:47, Mathieu Arnold wrote: >>> Author: mat >>> Date: Wed Sep 28 13:47:53 2016 >>> New Revision: 422874 >>> URL: https://svnweb.freebsd.org/changeset/ports/422874 >>> >>> Log: >>> Also, you can't set SSL_DEFAULT, and don't give bad advices to people, >>> it should never be set directly, but always through DEFAULT_VERSIONS. >>> >> >> fair point about setting though DEFAULT_VERSIONS, but it appears to me >> this is purely a semantic policy. From looking at the code, there's >> no technical issue with setting SSL_DEFAULT instead. It's just doing >> it before bsd.default-versions.mk can do exactly the same thing. >> >> I'm fine with this "just use DEFAULT_VERSIONS+=" policy but I did want >> to be pedantic that the other way caused no problem. (and is actually >> more intuitive but that's neither here nor there) > > There. can. only. be. one. system-wide. default. > > Setting SSL_DEFAULT is the same as setting DEFAULT_VERSIONS in a port, > you don't do it, because then, it is not system wide. What started this > is what I fixed in r422872, if you are running 9 with libressl, mysql > would not build because it would try to install openssl. Again, to be pedantic, I'm talking about /etc/make.conf. If "DEFAULT_SSL=openssl" is set the /etc/make.conf, it's system wide. It's defined in one spot. You fixed those issues correctly. Those were setting in the ports makefile, which is not the same as setting in make.conf. Ok? You agree? --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b809192c-1a26-075c-72ff-94fcc94357d1>