Date: Wed, 9 Aug 2017 02:57:21 +0800 From: Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org> To: Mathieu Arnold <mat@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, Joseph Mingrone <jrm@freebsd.org> Subject: Re: svn commit: r447474 - head/www/rubygem-goldfinger Message-ID: <CAMHz58ShY8c=HWoxk0yN_PgfuLq7TaNsEhoVVw_C8qAkOD5WcA@mail.gmail.com> In-Reply-To: <939bd115-95a7-f0dc-f018-b276488a091c@FreeBSD.org> References: <201708061653.v76Gr9O9008539@repo.freebsd.org> <939bd115-95a7-f0dc-f018-b276488a091c@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Aug 7, 2017 at 4:53 AM, Mathieu Arnold <mat@freebsd.org> wrote: > Hi, > > Le 06/08/2017 =C3=A0 18:53, Sunpoet Po-Chuan Hsieh a =C3=A9crit : > > Author: sunpoet > > Date: Sun Aug 6 16:53:09 2017 > > New Revision: 447474 > > URL: https://svnweb.freebsd.org/changeset/ports/447474 > > > > Log: > > Use PORTVERSION > > Please revert. DISTVERSION is the preferred way of setting upstream's > version. > > https://www.freebsd.org/doc/en/books/porters-handbook/makefi > le-naming.html#makefile-versions Hi mat, Here's my reason of this change. (jrm@ is cc'd). The majority of the ports tree (and almost all rubygem ports) use PORTVERSION. [1] It's my understanding that we use PORTVERSION in most cases. When upstream use versions like 1_2_3, 4.5-alpha6 or so, we use DISTVERSION instead. Before I revert it, could you make it clear when to use PORTVERSION and DISTVERSION? Thanks. [1] Search PORTVERSION in Makefile: https://github.com/freebsd/freebsd-ports/search?l=3DMakefile&; q=3DPORTVERSION&type=3D&utf8=3D%E2%9C%93 24,869 code results in freebsd/freebsd-ports Search DISTVERSION in Makefile: https://github.com/freebsd/freebsd-ports/search?l=3DMakefile&; q=3DDISTVERSION&type=3D&utf8=3D%E2%9C%93 1,375 code results in freebsd/freebsd-ports Regards, sunpoet > > > > Modified: > > head/www/rubygem-goldfinger/Makefile > > > > Modified: head/www/rubygem-goldfinger/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > --- head/www/rubygem-goldfinger/Makefile Sun Aug 6 16:53:04 2017 > (r447473) > > +++ head/www/rubygem-goldfinger/Makefile Sun Aug 6 16:53:09 2017 > (r447474) > > @@ -1,7 +1,7 @@ > > # $FreeBSD$ > > > > PORTNAME=3D goldfinger > > -DISTVERSION=3D 2.0.1 > > +PORTVERSION=3D 2.0.1 > > CATEGORIES=3D www rubygems > > MASTER_SITES=3D RG > > > > @@ -17,7 +17,6 @@ RUN_DEPENDS=3D rubygem-addressable>=3D2.5:www/= r > ubygem-addr > > rubygem-oj>=3D3.0:devel/rubygem-oj > > > > NO_ARCH=3D yes > > - > > USES=3D gem > > USE_RUBY=3D yes > > > > > > > > -- > Mathieu Arnold > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58ShY8c=HWoxk0yN_PgfuLq7TaNsEhoVVw_C8qAkOD5WcA>