From owner-svn-src-all@freebsd.org Wed Apr 10 15:55:18 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1BA601586296; Wed, 10 Apr 2019 15:55:18 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 28D1A7772D; Wed, 10 Apr 2019 15:55:17 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id x3AFt9DZ080091 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 10 Apr 2019 18:55:12 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua x3AFt9DZ080091 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id x3AFt99B080090; Wed, 10 Apr 2019 18:55:09 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 10 Apr 2019 18:55:09 +0300 From: Konstantin Belousov To: Edward Tomasz Napierala Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r346081 - head/cddl/usr.sbin/zfsd Message-ID: <20190410155509.GU1923@kib.kiev.ua> References: <201904101342.x3ADgbXM033389@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201904101342.x3ADgbXM033389@repo.freebsd.org> User-Agent: Mutt/1.11.4 (2019-03-13) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Apr 2019 15:55:18 -0000 On Wed, Apr 10, 2019 at 01:42:37PM +0000, Edward Tomasz Napierala wrote: > Author: trasz > Date: Wed Apr 10 13:42:37 2019 > New Revision: 346081 > URL: https://svnweb.freebsd.org/changeset/base/346081 > > Log: > Make zfsd(8) build obey CFLAGS. > > Reviewed by: imp > Obtained from: CheriBSD > MFC after: 2 weeks > Sponsored by: DARPA, AFRL > Differential Revision: https://reviews.freebsd.org/D19865 > > Modified: > head/cddl/usr.sbin/zfsd/Makefile.common > > Modified: head/cddl/usr.sbin/zfsd/Makefile.common > ============================================================================== > --- head/cddl/usr.sbin/zfsd/Makefile.common Wed Apr 10 13:41:34 2019 (r346080) > +++ head/cddl/usr.sbin/zfsd/Makefile.common Wed Apr 10 13:42:37 2019 (r346081) > @@ -30,7 +30,7 @@ INCFLAGS+= -I${SRCTOP}/sys/cddl/contrib/opensolaris/ut > INCFLAGS+= -I${SRCTOP}/sys/cddl/contrib/opensolaris/uts/common/fs/zfs > INCFLAGS+= -I${SRCTOP}/cddl/usr.sbin > > -CFLAGS= -g -DNEED_SOLARIS_BOOLEAN ${INCFLAGS} > +CFLAGS+= -g -DNEED_SOLARIS_BOOLEAN ${INCFLAGS} Why the flags unconditionally set -g ? > > LIBADD+= devdctl zfs zfs_core util geom bsdxml sbuf nvpair uutil >