From nobody Tue Apr 4 18:10:50 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PrbRJ580Xz43yJM; Tue, 4 Apr 2023 18:10:52 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-oa1-x35.google.com (mail-oa1-x35.google.com [IPv6:2001:4860:4864:20::35]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PrbRJ0PlFz45bL; Tue, 4 Apr 2023 18:10:52 +0000 (UTC) (envelope-from mjguzik@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-oa1-x35.google.com with SMTP id 586e51a60fabf-17aeb49429eso35588848fac.6; Tue, 04 Apr 2023 11:10:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680631851; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jdb43JMj+IsMWhkCe7TnRXmblhfALTu0/KCghCfCHwg=; b=C58ERsgiOPTyhJLwJTCFC+VXWsbBLfOIYlNSnwaC2y5DnfvopmPZ5KgEEH/fu9uUXG l+UYbIFWG/HnlhKqSdPV8dphn3bLiEeJj0PZsOyK+9S3UPAhb7Wq0nKUGn3cEZf0mkhD mzw66wnvoZEbNcWVqlk/HLlB9s3xJoRjyB/6Xb2LWBwwaPgaWift9kMXJkPEiwYf0s2o BBxQIluN0/fzDbH4rxBodCnt98T9mokORtX1s7SI2oGCKHWE6r7o233q76ML0qOHMKH1 duCR4dEK9g+acI+Q7g9402qbGJNjmjTnmGSOHmBHkZy1IqDm53/b7pKsEhBUqXVUTmNP Vqog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680631851; h=cc:to:subject:message-id:date:from:references:in-reply-to :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jdb43JMj+IsMWhkCe7TnRXmblhfALTu0/KCghCfCHwg=; b=pv13qRanatwx4hfM2VVJNg9wLZzzNzSDZ+Sj/ivfIH+Z44wrBdaorq0Nl5Wr4c2JS6 u7w7LaYxzzo1T1wj/djKU6CLROPVsxxjtG0+7tUj8ALsD2dms8IQkqPUs4LzpoPJaeFM vbLqGaZGpf2vbukFEGsc0FRL9SBybytBiB/jdMw83v/vrfIDlhZFQfcB+uB2iiaeVR9K i7r6tuJO0AcBMSGZdt+hN3cHNXMIzVsdSLny2+vJNGDXXgvmMKnL1guL8p9jpOJCjwHM 8IubafBaT6Ny5+EwbHtXLFL7Exdl9aT5kTv5xSjQkg2HBELDMH/ubtfVpKdIiyg7c11c CWkg== X-Gm-Message-State: AAQBX9eQLQ6MvMfcXJQDKcMgJqon6OWqXjXfhYik84TaXnQB0mRvix6Y ODOwHlC7cGZKDtb032xVGMIpWGJ8srmU4Lau9ITNICVz X-Google-Smtp-Source: AKy350YaedNvCFQC2H4XKoEghUM0+9lz/6ZPouTeq4nhmgXQf+R+8HgAL9drcyZndcBSjNmkBuERzx9NxDbCQc3M9VA= X-Received: by 2002:a05:6870:55:b0:177:c436:feb8 with SMTP id 21-20020a056870005500b00177c436feb8mr1732593oaz.4.1680631851019; Tue, 04 Apr 2023 11:10:51 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Received: by 2002:a8a:791:0:b0:49c:b071:b1e3 with HTTP; Tue, 4 Apr 2023 11:10:50 -0700 (PDT) In-Reply-To: <20230404093418.3041ff23@slippy> References: <202304041145.334Bjx6l035872@gitrepo.freebsd.org> <20230404141717.B976D31C@slippy.cwsent.com> <98c71e6f-5b48-79f3-e7b0-95d674949624@FreeBSD.org> <20230404091844.639cb1c1@slippy> <20230404093418.3041ff23@slippy> From: Mateusz Guzik Date: Tue, 4 Apr 2023 20:10:50 +0200 Message-ID: Subject: Re: git: 8ee579abe09e - main - zfs: fall back if block_cloning feature is disabled To: Cy Schubert Cc: Martin Matuska , Rick Macklem , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4PrbRJ0PlFz45bL X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2001:4860:4864::/48, country:US]; TAGGED_RCPT(0.00)[] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N can you please post a review On 4/4/23, Cy Schubert wrote: > The previously posted patch containing the following fixes all > regressions discussed so far: > > - Rick's fix null ap->a_fsizetd NULL pointer derefernce > - Rick's call vn_generic_copy_file_range() when block_cloning is > disabled > - Martin's call vn_generic_copy_file_range() when any other error > resulting in EXDEV > > > -- > Cheers, > Cy Schubert > FreeBSD UNIX: Web: https://FreeBSD.org > NTP: Web: https://nwtime.org > > e^(i*pi)+1=0 > > > On Tue, 4 Apr 2023 09:18:44 -0700 > Cy Schubert wrote: > >> On Tue, 4 Apr 2023 17:30:25 +0200 >> Martin Matuska wrote: >> >> > So I am now a little bit confused - what is the consensus? :-) >> >> My exmh email client made a mess of that. Let's try this again. >> >> Rick has posted a patch. Your patch should also be incorporated to work >> around other EXDEV errors, but a few lines earlier so it is protected by >> the lock. >> >> There were a couple of typos in Rick's patch (a missing keystroke; >> s/ojset/objset/). >> >> The patch (Rick's null pointer dereference fix, Rick's copy file range >> patch plus your copy file range patch) builds fine on amd64 and i386. >> Installing and testing it now. >> >> A combination of all three patches is attached. It's compile tested but is >> >> currently being installed and will be tested when install is completed. >> > > -- Mateusz Guzik