From owner-freebsd-bugs@FreeBSD.ORG Sun Apr 1 02:50:13 2012 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 48664106566C for ; Sun, 1 Apr 2012 02:50:13 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 05E0C8FC12 for ; Sun, 1 Apr 2012 02:50:13 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q312oCDf084147 for ; Sun, 1 Apr 2012 02:50:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q312oC85084146; Sun, 1 Apr 2012 02:50:12 GMT (envelope-from gnats) Resent-Date: Sun, 1 Apr 2012 02:50:12 GMT Resent-Message-Id: <201204010250.q312oC85084146@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Masaki TAGAWA Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 041B8106566C for ; Sun, 1 Apr 2012 02:46:43 +0000 (UTC) (envelope-from masaki@sakura.mochipon.com) Received: from sakura.mochipon.com (unknown [IPv6:2001:e41:db5e:ea20::1]) by mx1.freebsd.org (Postfix) with ESMTP id 9FA428FC0A for ; Sun, 1 Apr 2012 02:46:42 +0000 (UTC) Received: from sakura.mochipon.com (localhost [127.0.0.1]) by sakura.mochipon.com (8.14.5/8.14.5) with ESMTP id q312kfpg012649 for ; Sun, 1 Apr 2012 11:46:41 +0900 (JST) (envelope-from masaki@sakura.mochipon.com) Received: (from masaki@localhost) by sakura.mochipon.com (8.14.5/8.14.5/Submit) id q312kaoZ012648; Sun, 1 Apr 2012 11:46:36 +0900 (JST) (envelope-from masaki) Message-Id: <201204010246.q312kaoZ012648@sakura.mochipon.com> Date: Sun, 1 Apr 2012 11:46:36 +0900 (JST) From: Masaki TAGAWA To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: kern/166550: [patch] Some log lines about arp do not include the new-line X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Masaki TAGAWA List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Apr 2012 02:50:13 -0000 >Number: 166550 >Category: kern >Synopsis: [patch] Some log lines about arp do not include the new-line >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Apr 01 02:50:12 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Masaki TAGAWA >Release: FreeBSD 9.0-RELEASE amd64 >Organization: Kyushu Institute of Technology >Environment: System: FreeBSD sakura.mochipon.com 9.0-RELEASE FreeBSD 9.0-RELEASE #1: Sat Mar 31 12:00:48 JST 2012 root@sakura.mochipon.com:/usr/obj/usr/src/sys/SAKURA-VPS amd64 >Description: Some log lines about arp do not include the new-line. It is simple to add "\n". >How-To-Repeat: - Get those logs at syslog. >Fix: --- if_ether.patch begins here --- --- /usr/src/sys/netinet/if_ether.c.org 2012-01-03 12:26:27.000000000 +0900 +++ /usr/src/sys/netinet/if_ether.c 2012-04-01 11:32:52.393826736 +0900 @@ -543,7 +543,7 @@ } if (ETHER_IS_MULTICAST(ar_sha(ah))) { - log(LOG_ERR, "in_arp: source hardware address is multicast."); + log(LOG_ERR, "in_arp: source hardware address is multicast.\n"); return; } @@ -717,7 +717,7 @@ if (ifp->if_addrlen != ah->ar_hln) { LLE_WUNLOCK(la); log(LOG_WARNING, - "arp from %*D: addr len: new %d, i/f %d (ignored)", + "arp from %*D: addr len: new %d, i/f %d (ignored)\n", ifp->if_addrlen, (u_char *) ar_sha(ah), ":", ah->ar_hln, ifp->if_addrlen); goto drop; --- if_ether.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: