Date: Sun, 1 Apr 2012 11:46:36 +0900 (JST) From: Masaki TAGAWA <masaki@club.kyutech.ac.jp> To: FreeBSD-gnats-submit@FreeBSD.org Subject: kern/166550: [patch] Some log lines about arp do not include the new-line Message-ID: <201204010246.q312kaoZ012648@sakura.mochipon.com> Resent-Message-ID: <201204010250.q312oC85084146@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 166550
>Category: kern
>Synopsis: [patch] Some log lines about arp do not include the new-line
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Apr 01 02:50:12 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Masaki TAGAWA
>Release: FreeBSD 9.0-RELEASE amd64
>Organization:
Kyushu Institute of Technology
>Environment:
System: FreeBSD sakura.mochipon.com 9.0-RELEASE FreeBSD 9.0-RELEASE #1: Sat Mar 31 12:00:48 JST 2012 root@sakura.mochipon.com:/usr/obj/usr/src/sys/SAKURA-VPS amd64
>Description:
Some log lines about arp do not include the new-line.
It is simple to add "\n".
>How-To-Repeat:
- Get those logs at syslog.
>Fix:
--- if_ether.patch begins here ---
--- /usr/src/sys/netinet/if_ether.c.org 2012-01-03 12:26:27.000000000 +0900
+++ /usr/src/sys/netinet/if_ether.c 2012-04-01 11:32:52.393826736 +0900
@@ -543,7 +543,7 @@
}
if (ETHER_IS_MULTICAST(ar_sha(ah))) {
- log(LOG_ERR, "in_arp: source hardware address is multicast.");
+ log(LOG_ERR, "in_arp: source hardware address is multicast.\n");
return;
}
@@ -717,7 +717,7 @@
if (ifp->if_addrlen != ah->ar_hln) {
LLE_WUNLOCK(la);
log(LOG_WARNING,
- "arp from %*D: addr len: new %d, i/f %d (ignored)",
+ "arp from %*D: addr len: new %d, i/f %d (ignored)\n",
ifp->if_addrlen, (u_char *) ar_sha(ah), ":",
ah->ar_hln, ifp->if_addrlen);
goto drop;
--- if_ether.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201204010246.q312kaoZ012648>