From owner-freebsd-cvsweb@FreeBSD.ORG  Wed Feb 27 16:43:03 2008
Return-Path: <owner-freebsd-cvsweb@FreeBSD.ORG>
Delivered-To: cvsweb@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5442F1065670
	for <cvsweb@freebsd.org>; Wed, 27 Feb 2008 16:43:03 +0000 (UTC)
	(envelope-from MKoopman@omniture.com)
Received: from EXCHANGE0.orm.omniture.com (exchange0.orm.omniture.com
	[64.0.193.239]) by mx1.freebsd.org (Postfix) with ESMTP id 50ABB8FC20
	for <cvsweb@freebsd.org>; Wed, 27 Feb 2008 16:43:03 +0000 (UTC)
	(envelope-from MKoopman@omniture.com)
Received: from exchange05.orm.omniture.com ([10.100.10.22]) by
	EXCHANGE0.orm.omniture.com with Microsoft SMTPSVC(6.0.3790.3959); 
	Wed, 27 Feb 2008 09:21:02 -0700
X-MimeOLE: Produced By Microsoft Exchange V6.5
Content-class: urn:content-classes:message
MIME-Version: 1.0
Date: Wed, 27 Feb 2008 08:16:01 -0800
Message-ID: <9B4F3DF197EBF24C8496ADAE488DAEFE1F0B10@exchange05.orm.omniture.com>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: problem with colored diffs
Thread-Index: Ach5PjByMi2XyQwsQZyRMAbvmoybfQAHds2x
References: <20080227121008.GA9816@bewilderbeast.blackhelicopters.org>
From: "Mark Koopman" <MKoopman@omniture.com>
To: "Michael W. Lucas" <mwlucas@blackhelicopters.org>,
	<cvsweb@freebsd.org>
X-OriginalArrivalTime: 27 Feb 2008 16:21:02.0644 (UTC)
	FILETIME=[BEE12F40:01C8795C]
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
X-Content-Filtered-By: Mailman/MimeDel 2.1.5
Cc: 
Subject: RE: problem with colored diffs
X-BeenThere: freebsd-cvsweb@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS Web maintenance mailing list <freebsd-cvsweb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-cvsweb>, 
	<mailto:freebsd-cvsweb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-cvsweb>
List-Post: <mailto:freebsd-cvsweb@freebsd.org>
List-Help: <mailto:freebsd-cvsweb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-cvsweb>,
	<mailto:freebsd-cvsweb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Feb 2008 16:43:03 -0000

We had a similar problem with diffs in general, and
I had to add a call to umask to fix the problem.

  ## line 2338 cvsweb
  if (!open($fh, "-|")) {    # child
    open(STDERR, ">&STDOUT");    # Redirect stderr to stdout
    openOutputFilter();
    # adding umask to fix CVSWEB diff
    umask 0022;
    exec($CMD{rcsdiff}, @rcsdiff_options, @difftype, "-r$rev1", =
"-r$rev2",
         $fullname) or exit -1;
  }

diff cvsweb.cgi.orig cvsweb.cgi
2337a2338
>    # adding umask to fix CVSWEB diff
>    umask 0022;


-----Original Message-----
From: owner-freebsd-cvsweb@freebsd.org on behalf of Michael W. Lucas
Sent: Wed 2/27/2008 4:10 AM
To: cvsweb@freebsd.org
Subject: problem with colored diffs
=20
Hi,

I'm using cvsweb-3.0.6_1 on FreeBSD/amd64 7.0-beta2.

Everything except the colored diffs works flawlessly.

When I try to get a colored diff, however, the page comes up blank.
No error message is logged in the Apache logs or in /var/log/messages;
it appears to fail silently.

Any suggestions on how I can capture an error message, or otherwise
debug this further?

Thanks,
=3D=3Dml

--=20
Michael W. Lucas 	mwlucas@BlackHelicopters.org, mwlucas@FreeBSD.org
		http://www.BlackHelicopters.org/~mwlucas/
      Now Shipping: "Absolute FreeBSD" -- http://www.AbsoluteFreeBSD.com
On 5/4/2007, the TSA kept 3 pairs of my soiled undies "for security =
reasons."
_______________________________________________
freebsd-cvsweb@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-cvsweb
To unsubscribe, send any mail to =
"freebsd-cvsweb-unsubscribe@freebsd.org"