From owner-cvs-all@FreeBSD.ORG Wed Sep 28 07:03:04 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9B36116A41F; Wed, 28 Sep 2005 07:03:04 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 45A8E43D49; Wed, 28 Sep 2005 07:03:04 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8S734G4090378; Wed, 28 Sep 2005 07:03:04 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8S734w3090377; Wed, 28 Sep 2005 07:03:04 GMT (envelope-from rwatson) Message-Id: <200509280703.j8S734w3090377@repoman.freebsd.org> From: Robert Watson Date: Wed, 28 Sep 2005 07:03:04 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/alpha/alpha trap.c src/sys/alpha/osf1 osf1_ioctl.c osf1_misc.c osf1_signal.c src/sys/amd64/amd64 trap.c src/sys/compat/linux linux_socket.c src/sys/compat/svr4 svr4_fcntl.c svr4_ioctl.c svr4_ipc.c svr4_misc.c svr4_signal.c ... X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Sep 2005 07:03:04 -0000 rwatson 2005-09-28 07:03:04 UTC FreeBSD src repository Modified files: sys/alpha/alpha trap.c sys/alpha/osf1 osf1_ioctl.c osf1_misc.c osf1_signal.c sys/amd64/amd64 trap.c sys/compat/linux linux_socket.c sys/compat/svr4 svr4_fcntl.c svr4_ioctl.c svr4_ipc.c svr4_misc.c svr4_signal.c svr4_stat.c svr4_stream.c svr4_termios.c svr4_ttold.c svr4_util.h sys/gnu/fs/ext2fs ext2_alloc.c sys/i386/i386 trap.c vm86.c sys/ia64/ia64 unaligned.c sys/kern imgact_elf.c sys/ufs/ffs ffs_alloc.c Log: Back out alpha/alpha/trap.c:1.124, osf1_ioctl.c:1.14, osf1_misc.c:1.57, osf1_signal.c:1.41, amd64/amd64/trap.c:1.291, linux_socket.c:1.60, svr4_fcntl.c:1.36, svr4_ioctl.c:1.23, svr4_ipc.c:1.18, svr4_misc.c:1.81, svr4_signal.c:1.34, svr4_stat.c:1.21, svr4_stream.c:1.55, svr4_termios.c:1.13, svr4_ttold.c:1.15, svr4_util.h:1.10, ext2_alloc.c:1.43, i386/i386/trap.c:1.279, vm86.c:1.58, unaligned.c:1.12, imgact_elf.c:1.164, ffs_alloc.c:1.133: Now that Giant is acquired in uprintf() and tprintf(), the caller no longer leads to acquire Giant unless it also holds another mutex that would generate a lock order reversal when calling into these functions. Specifically not backed out is the acquisition of Giant in nfs_socket.c and rpcclnt.c, where local mutexes are held and would otherwise violate the lock order with Giant. This aligns this code more with the eventual locking of ttys. Suggested by: bde Revision Changes Path 1.125 +0 -2 src/sys/alpha/alpha/trap.c 1.15 +0 -4 src/sys/alpha/osf1/osf1_ioctl.c 1.58 +0 -4 src/sys/alpha/osf1/osf1_misc.c 1.42 +6 -24 src/sys/alpha/osf1/osf1_signal.c 1.293 +0 -2 src/sys/amd64/amd64/trap.c 1.61 +0 -2 src/sys/compat/linux/linux_socket.c 1.37 +2 -4 src/sys/compat/svr4/svr4_fcntl.c 1.24 +0 -2 src/sys/compat/svr4/svr4_ioctl.c 1.19 +0 -2 src/sys/compat/svr4/svr4_ipc.c 1.82 +0 -2 src/sys/compat/svr4/svr4_misc.c 1.35 +1 -4 src/sys/compat/svr4/svr4_signal.c 1.22 +0 -2 src/sys/compat/svr4/svr4_stat.c 1.56 +2 -26 src/sys/compat/svr4/svr4_stream.c 1.14 +0 -9 src/sys/compat/svr4/svr4_termios.c 1.16 +0 -24 src/sys/compat/svr4/svr4_ttold.c 1.11 +1 -4 src/sys/compat/svr4/svr4_util.h 1.44 +0 -2 src/sys/gnu/fs/ext2fs/ext2_alloc.c 1.280 +0 -2 src/sys/i386/i386/trap.c 1.59 +0 -2 src/sys/i386/i386/vm86.c 1.13 +0 -4 src/sys/ia64/ia64/unaligned.c 1.165 +0 -6 src/sys/kern/imgact_elf.c 1.134 +0 -6 src/sys/ufs/ffs/ffs_alloc.c