Date: Tue, 05 May 2015 13:41:22 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 199929] [NEW PORT] math/cryptominisat Message-ID: <bug-199929-13-M4XwmxT5LP@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-199929-13@https.bugs.freebsd.org/bugzilla/> References: <bug-199929-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D199929 --- Comment #1 from Jan Beich <jbeich@FreeBSD.org> --- Comment on attachment 156338 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D156338 Patch with new port $ portlint -AC WARN: /usr/ports/math/cryptominisat/pkg-plist: [8]: installing shared libraries, please define USE_LDCONFIG as appropriate FATAL: /usr/ports/math/cryptominisat/pkg-plist: the last line has to be terminated by \n. >+++ math/cryptominisat/Makefile 2015-05-02 22:20:57.733228258 +0300 [...] >+.include <bsd.port.options.mk> >+ >+.if ${PORT_OPTIONS:MPYTHON} New ports should use option helpers if possible. https://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html= #options-helpers >+USES+=3D python:build USES=3Dpython with no version specified is for ports that support both python2 and python3. CMakeLists.txt seems to disagree: find_package (PythonInterp 2.7) find_package (PythonLibs 2.7) >+PLIST_SUB+=3D EGGFILE=3Dpycryptosat-${PORTVERSION}-py${PYTHON_VER}.egg-in= fo >+.else >+CMAKE_ARGS+=3D -DPYTHON_EXECUTABLE=3D0 >+.endif >++++ python/CMakeLists.txt >+@@ -12,7 +12,7 @@ add_custom_command(OUTPUT ${OUTPUT}/time >+=20 >+ add_custom_target(pytarget ALL DEPENDS ${OUTPUT}/timestamp) >+=20 >+-install(CODE "execute_process(COMMAND ${PYTHON_EXECUTABLE} ${SETUP_PY} i= nstall --record files.txt)") >++install(CODE "execute_process(COMMAND ${PYTHON_EXECUTABLE} ${SETUP_PY} i= nstall -c -O1 --prefix=3D${CMAKE_INSTALL_PREFIX} --root=3D${FREEBSD_STAGEDI= R} --record files.txt)") Why not create a separate USE_PYTHON=3Ddistutils port that depends on this = one? >+++ math/cryptominisat/pkg-plist 2015-05-02 16:26:25.333693829 +0300 >@@ -0,0 +1,10 @@ [...] >+lib/libcryptominisat4.so Maybe set SOVERSION, so the library path can be cached by ldconfig(8) and used not only via RPATH. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-199929-13-M4XwmxT5LP>