From owner-svn-ports-head@FreeBSD.ORG  Sun Jul 20 11:27:24 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id B9A82D14;
 Sun, 20 Jul 2014 11:27:24 +0000 (UTC)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 8F0562AF7;
 Sun, 20 Jul 2014 11:27:24 +0000 (UTC)
Received: from [192.168.0.22] (unknown [130.255.19.191])
 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id BC287438BD;
 Sun, 20 Jul 2014 06:26:57 -0500 (CDT)
Message-ID: <53CBA770.2010409@marino.st>
Date: Sun, 20 Jul 2014 13:26:40 +0200
From: John Marino <freebsd.contact@marino.st>
Reply-To: marino@freebsd.org
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:24.0) Gecko/20100101 Thunderbird/24.5.0
MIME-Version: 1.0
To: Tijl Coosemans <tijl@FreeBSD.org>, John Marino <marino@FreeBSD.org>
Subject: Re: svn commit: r362304 - head/x11-toolkits/pango
References: <201407200815.s6K8FG8b003096@svn.freebsd.org>
 <20140720132259.156d687e@kalimero.tijl.coosemans.org>
In-Reply-To: <20140720132259.156d687e@kalimero.tijl.coosemans.org>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@freebsd.org, kwm@FreeBSD.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 20 Jul 2014 11:27:24 -0000

On 7/20/2014 13:22, Tijl Coosemans wrote:
> On Sun, 20 Jul 2014 08:15:16 +0000 (UTC) John Marino wrote:
>> Author: marino
>> Date: Sun Jul 20 08:15:16 2014
>> New Revision: 362304
>> URL: http://svnweb.freebsd.org/changeset/ports/362304
>> QAT: https://qat.redports.org/buildarchive/r362304/
>>
>> Log:
>>   x11-toolkits/pango: require explicit linking
>>   
>>   This new configure argument will list all required libraries in the
>>   generated pkgconf files.  Before any library indirectly pulled in, such
>>   as libm, was not listed.
>>   
>>   This fixes numerous regression in dports and it's more correct anyway.
> 
> No, this is wrong.  Each port should link to the libraries it needs on
> its own.  No port should rely on other ports to pull in libraries for
> them.

Then I guess we really don't need pkgconfig .pc files at all then?
(This is the point of .pc files, it tells how to link.  libm is directly
used by pango)

so no, it is not wrong.  The generated pc file was wrong, now it's not.
 This is why the configuration argument exists.