From owner-cvs-all Tue Nov 19 9:28: 6 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D9D4137B401; Tue, 19 Nov 2002 09:28:04 -0800 (PST) Received: from 12-234-90-219.client.attbi.com (12-234-90-219.client.attbi.com [12.234.90.219]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2590E43E75; Tue, 19 Nov 2002 09:28:04 -0800 (PST) (envelope-from DougB@FreeBSD.org) Received: from master.gorean.org (master.gorean.org [10.0.0.2]) by 12-234-90-219.client.attbi.com (8.12.6/8.12.6) with ESMTP id gAJHS1b1063139; Tue, 19 Nov 2002 09:28:01 -0800 (PST) (envelope-from DougB@FreeBSD.org) Received: from localhost (doug@localhost) by master.gorean.org (8.12.6/8.12.6/Submit) with ESMTP id gAJHRt1W009749; Tue, 19 Nov 2002 09:28:01 -0800 (PST) Date: Tue, 19 Nov 2002 09:27:55 -0800 (PST) From: Doug Barton To: Will Andrews Cc: Edwin Groothuis , , Subject: Re: cvs commit: ports/net/firedns/files patch-firemake.libs In-Reply-To: <20021119130550.GK79926@procyon.firepipe.net> Message-ID: <20021119092618.E7722-100000@master.gorean.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, 19 Nov 2002, Will Andrews wrote: > On Mon, Nov 18, 2002 at 11:42:15PM -0800, Doug Barton wrote: > > Since pthread has different values on different platforms, I use > > something like this in the Makefile: > > > > post-patch: > > @ ${CP} ${WRKSRC}/configure ${WRKSRC}/configure.Patched > > @ ${SED} -e 's#-lpthread#${PTHREAD_LIBS}#g' \ > > ${WRKSRC}/configure.Patched > ${WRKSRC}/configure > > You probably mean double quotes on that sed. Nope. I copied it straight from a Makefile that I know works. > Also, REINPLACE_CMD does the same thing with 1 command and doesn't leave > a temp file (well, you wouldn't if you used mv(1) and reversed the > order). True, but leaving one more extra file in WRKDIR is not a problem for me, and as you well know I think REINPLACE_CMD is an abomination. -- "We have known freedom's price. We have shown freedom's power. And in this great conflict, ... we will see freedom's victory." - George W. Bush, President of the United States State of the Union, January 28, 2002 Do YOU Yahoo!? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message