From owner-freebsd-current@FreeBSD.ORG Wed Apr 11 09:22:08 2007 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4577116A400; Wed, 11 Apr 2007 09:22:08 +0000 (UTC) (envelope-from keramida@freebsd.org) Received: from igloo.linux.gr (igloo.linux.gr [62.1.205.36]) by mx1.freebsd.org (Postfix) with ESMTP id B005A13C4B7; Wed, 11 Apr 2007 09:22:07 +0000 (UTC) (envelope-from keramida@freebsd.org) Received: from kobe.laptop (host5.bedc.ondsl.gr [62.103.39.229]) (authenticated bits=128) by igloo.linux.gr (8.13.8/8.13.8/Debian-3) with ESMTP id l3B9LMGn031164 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 11 Apr 2007 12:21:28 +0300 Received: from kobe.laptop (kobe.laptop [127.0.0.1]) by kobe.laptop (8.14.1/8.14.1) with ESMTP id l3B9L4Sg002921; Wed, 11 Apr 2007 12:21:16 +0300 (EEST) (envelope-from keramida@freebsd.org) Received: (from keramida@localhost) by kobe.laptop (8.14.1/8.14.1/Submit) id l3B9L4BO002920; Wed, 11 Apr 2007 12:21:04 +0300 (EEST) (envelope-from keramida@freebsd.org) Date: Wed, 11 Apr 2007 12:21:04 +0300 From: Giorgos Keramidas To: John Baldwin Message-ID: <20070411092104.GD1675@kobe.laptop> References: <4608A5D9.2010902@root.org> <20070406211229.GB1078@kobe.laptop> <461BEFD6.2050302@root.org> <200704101922.08255.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200704101922.08255.jhb@freebsd.org> X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-3.795, required 5, autolearn=not spam, ALL_TRUSTED -1.80, AWL 0.60, BAYES_00 -2.60) X-Hellug-MailScanner-From: keramida@freebsd.org X-Spam-Status: No Cc: current@freebsd.org, Ariff Abdullah , S?ren Schmidt , Nate Lawson Subject: Re: recent commits break via 8235 ata X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Apr 2007 09:22:08 -0000 On 2007-04-10 19:22, John Baldwin wrote: >On Tuesday 10 April 2007 16:13, Nate Lawson wrote: >>Giorgos Keramidas wrote: >>> This is the change which stops snd_hda from working here: >>> >>> % Revision Changes Path >>> % 1.233 +39 -55 src/sys/dev/acpica/acpi.c >>> >>> If I update my kernel sources to Wed Mar 21 14:39:39 2007 +0000 >>> (including the sys/modules/padlock/Makefile commit of Sam Leffler, to >>> fix the kernel build from Wed Mar 21 17:37:13 2007 +0000), I can see >>> that the snd_hda driver probes my sound card correctly. >>> >>> Updating after the commit shown above, breaks snd_hda. >> >> I just finished a binsearch and can verify this exact commit causes the >> problem for my ATA also. I'll spend some more time debugging it later. >> >> John, can I back out rev 1.233 of acpi.c until you return since it >> prevents some machines from booting? > > Well, it most likely means there are other bugs that just happen to > not break with the older stuff. Are you sure that just this one > change fixes things rather than the changes to the nexus drivers? For snd_hda on my Toshiba laptop, I can verify that reverting this changeset only makes snd_hda probe correctly again. I resynced to last night's HEAD version of CVS, reverted this change only, and the snd_hda drives still probes correctly. Rebuilding with rev 1.233 of acpi.c results in the same failure to attach with: pcm0: hdac_get_capabilities: Invalid rirb size (0) device_attach: pcm0 attach returned 6