From owner-freebsd-current@FreeBSD.ORG Sat May 7 15:30:59 2005 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A8DFF16A4DF for ; Sat, 7 May 2005 15:30:59 +0000 (GMT) Received: from avout1.midco.net (avout1.midco.net [24.220.0.100]) by mx1.FreeBSD.org (Postfix) with ESMTP id BF03743DAE for ; Sat, 7 May 2005 15:30:58 +0000 (GMT) (envelope-from pmes@bis.midco.net) Received: (qmail 30571 invoked by uid 1009); 7 May 2005 15:30:58 -0000 Received: from pmes@bis.midco.net by avout1 by uid 1002 with qmail-scanner-1.22 (f-prot: 4.4.2/3.14.11. Clear:RC:1(24.220.122.106):. Processed in 0.010713 secs); 07 May 2005 15:30:58 -0000 X-Qmail-Scanner-Mail-From: pmes@bis.midco.net via avout1 X-Qmail-Scanner: 1.22 (Clear:RC:1(24.220.122.106):. Processed in 0.010713 secs) Received: from host-106-122-220-24.midco.net (HELO [10.0.0.3]) ([24.220.122.106]) (envelope-sender ) by avout1.midco.net (qmail-ldap-1.03) with SMTP for ; 7 May 2005 15:30:58 -0000 In-Reply-To: <200505062004.34884.max@love2party.net> References: <20050502201921.4F0387306E@freebsd-current.sentex.ca> <4276C18F.1080207@freebsd.org> <200505062004.34884.max@love2party.net> Mime-Version: 1.0 (Apple Message framework v728) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: Peter Schultz Date: Sat, 7 May 2005 10:30:55 -0500 To: Max Laier X-Mailer: Apple Mail (2.728) cc: darrenr@freebsd.org cc: powerpc@freebsd.org cc: freebsd-current@freebsd.org cc: Peter Grehan Subject: IPFILTER Branch [was: Re: [current tinderbox] failure on powerpc/powerpc] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 May 2005 15:30:59 -0000 On May 6, 2005, at 1:04 PM, Max Laier wrote: > On Tuesday 03 May 2005 02:10, Peter Grehan wrote: >> I've sent mail to Darren about this: it's a PPC-only (well, >> maybe ARM >> as well) default-unsigned-char problem. For those that want to >> buildworld appended is the patch I'm using. >> >> later, >> >> Peter. >> >> RCS file: /home/ncvs/src/contrib/ipfilter/tools/ipmon.c,v >> retrieving revision 1.2 >> diff -u -r1.2 ipmon.c >> --- ipmon.c 25 Apr 2005 18:20:15 -0000 1.2 >> +++ ipmon.c 1 May 2005 08:42:53 -0000 >> @@ -1024,7 +1024,7 @@ >> (void) sprintf(t, "%*.*s%u", len, len, ipf->fl_ifname, >> ipf->fl_unit); >> t += strlen(t); >> #endif >> -#ifdef __sgi >> +#if (defined(__sgi) || defined(__powerpc__)) >> if ((ipf->fl_group[0] == 255) && (ipf->fl_group[1] == '\0')) >> #else >> if ((ipf->fl_group[0] == -1) && (ipf->fl_group[1] == '\0')) >> > > Just saw your mail now. Darren has had enough time to veto against > it. Please > go ahead, fix the build and shut up the tinderbox. Thanks! > Darren is on holiday, so you will not be getting a veto anytime soon. As an aside, Darren is so notorious for breaking the build, I don't know why anyone bothers complaining anymore. I'm beginning to think he does it just to get under people's skin. Either take away his privileges or accept that he will be breaking the build. Maybe there should be an IPFILTER branch where he can drop his bombs?