From owner-freebsd-bugs@FreeBSD.ORG Fri Jun 1 11:40:04 2007 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E028116A41F for ; Fri, 1 Jun 2007 11:40:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id AA0BF13C458 for ; Fri, 1 Jun 2007 11:40:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l51Be4HY008969 for ; Fri, 1 Jun 2007 11:40:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l51Be4YN008968; Fri, 1 Jun 2007 11:40:04 GMT (envelope-from gnats) Resent-Date: Fri, 1 Jun 2007 11:40:04 GMT Resent-Message-Id: <200706011140.l51Be4YN008968@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Vasim V Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9365E16A468 for ; Fri, 1 Jun 2007 11:30:08 +0000 (UTC) (envelope-from vasim@hunter.resume-bank.ru) Received: from wolf.resume-bank.ru (mail.resume-bank.ru [62.118.250.39]) by mx1.freebsd.org (Postfix) with SMTP id CDCDC13C44C for ; Fri, 1 Jun 2007 11:30:07 +0000 (UTC) (envelope-from vasim@hunter.resume-bank.ru) Received: (qmail 46124 invoked by uid 0); 1 Jun 2007 11:09:16 -0000 Received: from unknown (HELO hunter.resume-bank.ru) (62.118.252.51) by mail.resume-bank.ru with SMTP; 1 Jun 2007 11:09:16 -0000 Received: (from vasim@localhost) by hunter.resume-bank.ru (8.14.1/8.13.4/Submit) id l51B3OjV018332; Fri, 1 Jun 2007 15:03:24 +0400 (MSD) (envelope-from vasim) Message-Id: <200706011103.l51B3OjV018332@hunter.resume-bank.ru> Date: Fri, 1 Jun 2007 15:03:24 +0400 (MSD) From: Vasim V To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: kern/113218: Overflow in shmget's memory size check X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Vasim V List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jun 2007 11:40:05 -0000 >Number: 113218 >Category: kern >Synopsis: Overflow in shmget's memory size check >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Jun 01 11:40:03 GMT 2007 >Closed-Date: >Last-Modified: >Originator: Vasim V >Release: FreeBSD 7.0-CURRENT amd64 >Organization: Resume Bank ltd >Environment: System: FreeBSD hunter.resume-bank.ru 7.0-CURRENT FreeBSD 7.0-CURRENT #1: Wed May 30 15:59:46 MSD 2007 vasim@hunter.resume-bank.ru:/usr/src/sys/amd64/compile/NEWHUNTER amd64 >Description: I've got ENOMEM error when tried to allocate SYSV's shared memory buffer greater than 1G on machine with 16G RAM. Some investigation did show that there is small error in sys/kern/sysv_shm.c file - variable "size" has "int" type that may overflow on big values. >How-To-Repeat: Just try to allocate big shared memory buffer >Fix: *** sys/kern/sysv_shm.c.orig Fri Jun 1 14:49:47 2007 --- sys/kern/sysv_shm.c Fri Jun 1 14:50:50 2007 *************** *** 717,723 **** struct shmget_args *uap; int mode; { ! int i, segnum, shmid, size; struct ucred *cred = td->td_ucred; struct shmid_kernel *shmseg; vm_object_t shm_object; --- 717,724 ---- struct shmget_args *uap; int mode; { ! int i, segnum, shmid; ! size_t size; struct ucred *cred = td->td_ucred; struct shmid_kernel *shmseg; vm_object_t shm_object; >Release-Note: >Audit-Trail: >Unformatted: