From owner-freebsd-current  Wed Feb 27  1:49:13 2002
Delivered-To: freebsd-current@freebsd.org
Received: from rwcrmhc51.attbi.com (rwcrmhc51.attbi.com [204.127.198.38])
	by hub.freebsd.org (Postfix) with ESMTP id 6AD1A37B402
	for <current@FreeBSD.org>; Wed, 27 Feb 2002 01:49:10 -0800 (PST)
Received: from 12-234-22-238.client.attbi.com ([12.234.22.238])
          by rwcrmhc51.attbi.com
          (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP
          id <20020227094910.EVKI2626.rwcrmhc51.attbi.com@12-234-22-238.client.attbi.com>;
          Wed, 27 Feb 2002 09:49:10 +0000
Received: from master.gorean.org (root@master.gorean.org [10.0.0.2])
	by 12-234-22-238.client.attbi.com (8.11.6/8.11.6) with ESMTP id g1R9n5q53000;
	Wed, 27 Feb 2002 01:49:05 -0800 (PST)
	(envelope-from DougB@FreeBSD.org)
Received: from master.gorean.org (doug@localhost [127.0.0.1])
	by master.gorean.org (8.12.2/8.12.2) with ESMTP id g1R9n1LR041822;
	Wed, 27 Feb 2002 01:49:01 -0800 (PST)
	(envelope-from DougB@FreeBSD.org)
Received: from localhost (doug@localhost)
	by master.gorean.org (8.12.2/8.12.2/Submit) with ESMTP id g1R9mt5O041819;
	Wed, 27 Feb 2002 01:48:57 -0800 (PST)
X-Authentication-Warning: master.gorean.org: doug owned process doing -bs
Date: Wed, 27 Feb 2002 01:48:55 -0800 (PST)
From: Doug Barton <DougB@FreeBSD.org>
X-X-Sender: doug@master.gorean.org
To: Bruce Evans <bde@zeta.org.au>
Cc: Bill Fenner <fenner@research.att.com>, <current@FreeBSD.org>
Subject: Re: Broken (?) unistd.h
In-Reply-To: <20020227183827.R47743-100000@gamplex.bde.org>
Message-ID: <20020227014559.O31146-100000@master.gorean.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

On Wed, 27 Feb 2002, Bruce Evans wrote:

> On Tue, 26 Feb 2002, Bill Fenner wrote:
>
> > Here's a patch for bind's port/freebsd/include/port_before.h .
> >
> > --- port_before.h.orig	Tue Feb 26 20:57:35 2002
> > +++ port_before.h	Tue Feb 26 21:02:18 2002
> > @@ -15,6 +15,7 @@
> >  #define SETPWENT_VOID
> >  #endif
> >
> > +#include <sys/param.h>
> >  #include <sys/types.h>
>
> >From style(9):
>
>      Kernel include files (i.e. sys/*.h) come first; normally, include
>      <sys/types.h> OR <sys/param.h>, but not both.  <sys/types.h> includes
>      <sys/cdefs.h>, and it is okay to depend on that.

Based on a suggestion from someone else, I actually generated the same
patch that Bill did. Without including sys/param.h, there is no definition
of __FreeBSD_version at this point in the process, so the test always
fails. If there is a more correct way to test, I'll be glad to use it,
otherwise I'll have to go with what works.

Doug
-- 
   "We have known freedom's price. We have shown freedom's power.
      And in this great conflict, ...  we will see freedom's victory."
	- George W. Bush, President of the United States
          State of the Union, January 28, 2002

         Do YOU Yahoo!?



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message