From owner-svn-src-head@FreeBSD.ORG  Sun Dec 28 05:35:30 2008
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E5F8F106564A;
	Sun, 28 Dec 2008 05:35:30 +0000 (UTC)
	(envelope-from bright@elvis.mu.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.freebsd.org (Postfix) with ESMTP id C33CF8FC0C;
	Sun, 28 Dec 2008 05:35:30 +0000 (UTC)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id B21FE1A3C3D; Sat, 27 Dec 2008 21:35:30 -0800 (PST)
Date: Sat, 27 Dec 2008 21:35:30 -0800
From: Alfred Perlstein <alfred@freebsd.org>
To: Scott Long <scottl@samsco.org>
Message-ID: <20081228053530.GF18389@elvis.mu.org>
References: <4947D474.9040802@samsco.org>
	<20081216.101038.1172765453.imp@bsdimp.com>
	<4947F363.4010909@samsco.org>
	<20081216.120412.1346820326.imp@bsdimp.com>
	<20081227003826.GV18389@elvis.mu.org>
	<72A0CF67-F521-4C4B-955D-A80A77CC1165@samsco.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <72A0CF67-F521-4C4B-955D-A80A77CC1165@samsco.org>
User-Agent: Mutt/1.4.2.3i
Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>,
	"mav@freebsd.org" <mav@freebsd.org>,
	"src-committers@freebsd.org" <src-committers@freebsd.org>,
	"svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,
	"M. Warner Losh" <imp@bsdimp.com>
Subject: Re: svn commit: r186182 - head/sys/dev/ata
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 28 Dec 2008 05:35:31 -0000

* Scott Long <scottl@samsco.org> [081226 18:34] wrote:
> 
> On Dec 26, 2008, at 5:38 PM, Alfred Perlstein <alfred@freebsd.org>  
> wrote:
> >
> >Easy enough to stash a "once" varible in the generic device struct
> >and warn when returning from an isr when INVARIANTS or something is
> >turned on.
> >
> >Then you'd only get one warning per device once it happens.
> >
> >
> 
> I prefer to do nothing.  It's not unsafe or erroneous to access cfg  
> registers.  But if some kind of message does get added, I insist that  
> it drop all pretenses and say, "you're too poor to run freebsd, come  
> back when you can afford better hardware.". :)

Well that could be the result of a driver that has a "bug" that
makes it access cfg space when it does not need to, as what seems
to have just been fixed.

-- 
- Alfred Perlstein