From owner-svn-ports-svnadmin@freebsd.org Mon Sep 25 16:13:35 2017 Return-Path: Delivered-To: svn-ports-svnadmin@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 18126E1E7AD; Mon, 25 Sep 2017 16:13:35 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (prod2.absolight.net [79.143.243.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "plouf.absolight.net", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id BE4DE844EC; Mon, 25 Sep 2017 16:13:34 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id A9E83BDD2D; Mon, 25 Sep 2017 18:13:32 +0200 (CEST) Received: from ogg.in.absolight.net (ogg.in.absolight.net [79.143.241.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by prod2.absolight.net (Postfix) with ESMTPSA id 9D4A3BDD1E; Mon, 25 Sep 2017 18:13:32 +0200 (CEST) Subject: Re: svn commit: r450616 - svnadmin/hooks/scripts To: koobs@FreeBSD.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-svnadmin@freebsd.org, "portmgr@FreeBSD.org" References: <201709251537.v8PFbH7K018382@repo.freebsd.org> From: Mathieu Arnold Organization: Absolight / The FreeBSD Foundation Message-ID: <670f9498-c59e-8e2f-f394-a416a6f65145@FreeBSD.org> Date: Mon, 25 Sep 2017 18:13:32 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="l1J3G5HHJBtsOagraWbDucftVOi42h9fF" X-BeenThere: svn-ports-svnadmin@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for svnadmin of the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Sep 2017 16:13:35 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --l1J3G5HHJBtsOagraWbDucftVOi42h9fF Content-Type: multipart/mixed; boundary="WhScWojWHkTD5H2K6jKnwSjr8pLCeKGd5"; protected-headers="v1" From: Mathieu Arnold To: koobs@FreeBSD.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-svnadmin@freebsd.org, "portmgr@FreeBSD.org" Message-ID: <670f9498-c59e-8e2f-f394-a416a6f65145@FreeBSD.org> Subject: Re: svn commit: r450616 - svnadmin/hooks/scripts References: <201709251537.v8PFbH7K018382@repo.freebsd.org> In-Reply-To: --WhScWojWHkTD5H2K6jKnwSjr8pLCeKGd5 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: fr Le 25/09/2017 =C3=A0 17:47, Kubilay Kocak a =C3=A9crit=C2=A0: > On 9/26/17 1:37 AM, Mathieu Arnold wrote: >> Author: mat >> Date: Mon Sep 25 15:37:17 2017 >> New Revision: 450616 >> URL: https://svnweb.freebsd.org/changeset/ports/450616 >> >> Log: >> Flavors are coming soon, but first, forbid anyone from using it. >> =20 >> With hat: portmgr >> Sponsored by: Absolight >> >> Modified: >> svnadmin/hooks/scripts/stage-only.sh >> >> Modified: svnadmin/hooks/scripts/stage-only.sh >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- svnadmin/hooks/scripts/stage-only.sh Mon Sep 25 15:19:43 2017 (r45= 0615) >> +++ svnadmin/hooks/scripts/stage-only.sh Mon Sep 25 15:37:17 2017 (r45= 0616) >> @@ -34,6 +34,11 @@ for line in $(svnlook changed -t $TXN $REPO) ; do >> echo "NOPORTDATA is nonsense as a variable affecting all ports." 1= >&2 >> exit 1 >> fi >> + if svnlook cat -t ${TXN} ${REPO} $fpath | grep -q "^FLAVORS" ; then= >> + echo "Do not commit a port with FLAVORS without first" > 1>&2 >> + echo "getting approval from portmgr." 1>&2 >> + exit 1 >> + fi >> ;; >> head/*/*/pkg-plist*) >> if svnlook cat -t ${TXN} ${REPO} $fpath | grep -q "%%PORTDATA%%" ; = then >> > I just saw this on commit: > > svn: E165001: Commit failed (details follow): > svn: E165001: Commit blocked by pre-commit hook (exit code 1) with outp= ut: > /s/svn/ports/hooks/scripts/stage-only.sh: 38: Syntax error: redirection= > unexpected (expecting word) The fact that it is not possible to really test hook changes is annoying. I'll poke someone from clusteradm to help me un fuck this up. --=20 Mathieu Arnold --WhScWojWHkTD5H2K6jKnwSjr8pLCeKGd5-- --l1J3G5HHJBtsOagraWbDucftVOi42h9fF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJZySssXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IzrAQAJuTyPq9ALYzxBZE+qs89gid icQFMVCv98+muROG92v98GDh8ZXvlTQyx+A1YQ71uYNSIgeSpKuJcW2jVjJVJq3D 9dz3K4mUKs5OLOvtPPyJagcaLbwbtmb8e9iqLS9EJk8eiI7ZGhYrGq97LcR6jKHX CAV3P99G9yoKHQUD2INb/9eCqwX/JyuvrchDbeXMBLsdpJALl3mYZfQ1M/BvhXic NjpT+lsL5gKwfmTtZ6MIciPCO7dsyoodMdVuapsBAWd9iUP3Hm/ARa9Uu8EHpcHf f593xwkpK+WIGbkQiqZkUt3WFKLmx6e4DuyRqOVbNYvL8ww3TI3mERxfiUh9uuft T1g6k54tIuTzsVZ4t4rPA1r6KPshEaLVmJ9Mw7kj3tWarPtExOOJGDG8VPiQd/ZT 1Rc4Tj9N8mqrEVGu+miKvEXZ4QjcLgULEf7dq6J1FCLO/siYmHYSZurq+gMH6pMW wateD9TxRcZmPSPC2R+mXG2v7Tgq/mT1FT1YXfBr1HiBhUH56kt8pZtqb38a7Vn1 zQFqkAdJXcCLNB6kTv/7D5uGs5fIXk3erVgSHRT6j1kHds5m8PT2TrXLpmiFBQaH ExgywADygDo2KvONnQt8Dsy+Cg3N8pclo2S+5aA76/c3Wk5YGxgYALUV7CECJPqV 8CxLUlvHI/o9mZwKTc20 =uKb/ -----END PGP SIGNATURE----- --l1J3G5HHJBtsOagraWbDucftVOi42h9fF--