Date: Tue, 10 Apr 2012 23:54:27 +0100 From: Simon Moore <Simon.Moore@cl.cam.ac.uk> To: Jonathan Woodruff <jonwoodruff@gmail.com> Cc: Perforce Change Reviews <perforce@freebsd.org>, Robert Watson <rwatson@freebsd.org> Subject: Re: PERFORCE change 209388 for review Message-ID: <38688DAC-873E-40F1-B47D-CD33DF6523E3@cl.cam.ac.uk> In-Reply-To: <CA%2BoXuiKdqcWFCFNmqjDsqUnZKq2y3=LL5ymzG3abQUq=FaExWg@mail.gmail.com> References: <201204102200.q3AM0KjU068586@skunkworks.freebsd.org> <CA%2BoXuiKdqcWFCFNmqjDsqUnZKq2y3=LL5ymzG3abQUq=FaExWg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
RXhjZWxsZW50IG5ld3MhDQoNCi0gU2ltb24NCihzZW50IGZyb20gcGhvbmUsIHNvIHBsZWFzZSBl eGN1c2UgdGhlIGJyZXZpdHkpDQoNCltTaW1vbiBNb29yZV1baHR0cDovL3d3dy5jbC5jYW0uYWMu dWsgXQ0KDQpPbiAxMCBBcHIgMjAxMiwgYXQgMjM6MzUsICJKb25hdGhhbiBXb29kcnVmZiIgPGpv bndvb2RydWZmQGdtYWlsLmNvbTxtYWlsdG86am9ud29vZHJ1ZmZAZ21haWwuY29tPj4gd3JvdGU6 DQoNCllheSENCg0KT24gVHVlLCBBcHIgMTAsIDIwMTIgYXQgMTE6MDAgUE0sIFJvYmVydCBXYXRz b24gPHJ3YXRzb25AZnJlZWJzZC5vcmc8bWFpbHRvOnJ3YXRzb25AZnJlZWJzZC5vcmc+PiB3cm90 ZToNCmh0dHA6Ly9wNHdlYi5mcmVlYnNkLm9yZy9AQDIwOTM4OD9hYz0xMA0KDQpDaGFuZ2UgMjA5 Mzg4IGJ5IHJ3YXRzb25AcndhdHNvbl9zdnJfY3RzcmRfbWlwc2J1aWxkIG9uIDIwMTIvMDQvMTAg MjI6MDA6MDcNCg0KICAgICAgIE1vZGlmeSB0aGUgQWx0ZXJhIFNEIENhcmQgSVAgY29yZSBkcml2 ZXIgdG8gaWdub3JlIHRoZSBwcmVzZW5jZSBvZg0KICAgICAgIEFMVEVSQV9TRENBUkRfUlIxX0NP TU1BTkRDUkNGQUlMRUQgaW4gdGhlIFJSMSByZWdpc3RlciB3aGVuIGEgcmVhZA0KICAgICAgIGVy cm9yIGlzIHJlcG9ydGVkIGJ5IHRoZSBjb3JlLiAgSW4gbXkgKGxpbWl0ZWQpIHRlc3RzLCB0aGUg ZXJyb3INCiAgICAgICBiaXQgZG9lcyBub3QgcmVmbGVjdCBkYXRhIGNvcnJ1cHRpb24gaW4gdGhl IEkvTy4gIFdpdGggdGhpcyBjaGFuZ2UNCiAgICAgICBJIGFtIGFibGUgdG8gbW91bnQgYW5kIHVz ZSBVRlMgZmlsZSBzeXN0ZW1zIHJlbGlhYmx5IG9uIDJHQiBDU0QNCiAgICAgICBzdHJ1Y3R1cmUg MCBTRCBjYXJkcyBmcm9tIEZyZWVCU0QvQkVSSS4NCg0KQWZmZWN0ZWQgZmlsZXMgLi4uDQoNCi4u IC8vZGVwb3QvcHJvamVjdHMvY3RzcmQvYmVyaWJzZC9zcmMvc3lzL2Rldi9hbHRlcmEvc2RjYXJk L2FsdGVyYV9zZGNhcmQuaCM4IGVkaXQNCi4uIC8vZGVwb3QvcHJvamVjdHMvY3RzcmQvYmVyaWJz ZC9zcmMvc3lzL2Rldi9hbHRlcmEvc2RjYXJkL2FsdGVyYV9zZGNhcmRfaW8uYyMxMCBlZGl0DQoN CkRpZmZlcmVuY2VzIC4uLg0KDQo9PT09IC8vZGVwb3QvcHJvamVjdHMvY3RzcmQvYmVyaWJzZC9z cmMvc3lzL2Rldi9hbHRlcmEvc2RjYXJkL2FsdGVyYV9zZGNhcmQuaCM4ICh0ZXh0K2tvKSA9PT09 DQoNCkBAIC0xMTUsNyArMTE1LDYgQEANCiAqLw0KIHVpbnQxNl90ICAgICAgIGFsdGVyYV9zZGNh cmRfcmVhZF9hc3Ioc3RydWN0IGFsdGVyYV9zZGNhcmRfc29mdGMgKnNjKTsNCiBpbnQgICAgICAg ICAgICBhbHRlcmFfc2RjYXJkX3JlYWRfY3NkKHN0cnVjdCBhbHRlcmFfc2RjYXJkX3NvZnRjICpz Yyk7DQotdWludDE2X3QgICAgICAgYWx0ZXJhX3NkY2FyZF9yZWFkX3JyMShzdHJ1Y3QgYWx0ZXJh X3NkY2FyZF9zb2Z0YyAqc2MpOw0KDQogaW50ICAgIGFsdGVyYV9zZGNhcmRfaW9fY29tcGxldGUo c3RydWN0IGFsdGVyYV9zZGNhcmRfc29mdGMgKnNjLA0KICAgICAgICAgICB1aW50MTZfdCBhc3Ip Ow0KQEAgLTE4NSwxNCArMTg0LDI4IEBADQogI2RlZmluZSAgICAgICAgQUxURVJBX1NEQ0FSRF9B U1JfQ01EREFUQUVSUk9SICAweDAwMjANCg0KIC8qDQotICogVGhlIEFsdGVyYSBJUCBDb3JlIHBy b3ZpZGVzIGEgMTYtYml0ICJSZXNwb25zZSBSMSIgcmVnc3RlciAoUlIxKSBiZXlvbmQNCi0gKiB0 aG9zZSBkZXNjcmliZWQgaW4gdGhlIFNEIENhcmQgc3BlY2lmaWNhdGlvbiB0aGF0IGhvbGRzIGFk ZGl0aW9uYWwNCi0gKiBpbmZvcm1hdGlvbiBvbiB0aGUgbW9zdCByZWNlbnRseSBjb21wbGV0ZWQg Y29tbWFuZCBzZW50IHRvIHRoZSB1bml0Lg0KKyAqIFRoZSBBbHRlcmEgSVAgQ29yZSBjbGFpbXMg dG8gcHJvdmlkZSBhIDE2LWJpdCAiUmVzcG9uc2UgUjEiIHJlZ2lzdGVyIChSUjEpDQorICogdG8g cHJvdmlkZSBtb3JlIGRldGFpbGVkIGVycm9yIHJlcG9ydGluZyB3aGVuIGEgcmVhZCBvciB3cml0 ZSBmYWlscy4NCiAqDQogKiBYWFhSVzogVGhlIHNwZWNpZmljYXRpb24gY2xhaW1zIHRoYXQgdGhp cyBmaWVsZCBpcyAxNi1iaXQsIGJ1dCB0aGVuDQotICogcHJvY2VlZHMgdG8gZGVmaW5lIHZhbHVl cyBhcyB0aG91Z2ggaXQgaXMgMzItYml0LiAgV2hpY2ggcGllY2Ugb2YgdGhlDQotICogZG9jdW1l bnRhdGlvbiBpcyBjb3JyZWN0Pw0KKyAqIHByb2NlZWRzIHRvIGRlZmluZSB2YWx1ZXMgYXMgdGhv dWdoIGl0IGlzIDMyLWJpdC4gIEluIHByYWN0aWNlLCAxNi1iaXQNCisgKiBzZWVtcyBtb3JlIGxp a2VseSBhcyB0aGUgcmVnaXN0ZXIgaXMgbm90IDMyLWJpdCBhbGlnbmVkLg0KKyAqLw0KKyNkZWZp bmUgICAgICAgIEFMVEVSQV9TRENBUkRfUlIxX0lOSVRQUk9DUlVOTklORyAgICAgICAweDAxMDAN CisjZGVmaW5lICAgICAgICBBTFRFUkFfU0RDQVJEX1JSMV9FUkFTRUlOVEVSUlVQVEVEICAgICAg MHgwMjAwDQorI2RlZmluZSAgICAgICAgQUxURVJBX1NEQ0FSRF9SUjFfSUxMRUdBTENPTU1BTkQg ICAgICAgIDB4MDQwMA0KKyNkZWZpbmUgICAgICAgIEFMVEVSQV9TRENBUkRfUlIxX0NPTU1BTkRD UkNGQUlMRUQgICAgICAweDA4MDANCisjZGVmaW5lICAgICAgICBBTFRFUkFfU0RDQVJEX1JSMV9B RERSRVNTTUlTQUxJR05FRCAgICAgMHgxMDAwDQorI2RlZmluZSAgICAgICAgQUxURVJBX1NEQ0FS RF9SUjFfQUREUkJMT0NLUkFOR0UgICAgICAgIDB4MjAwMA0KKw0KKy8qDQorICogTm90IGFsbCBS UjEgdmFsdWVzIGFyZSAiZXJyb3JzIiBwZXIgc2UgLS0gY2hlY2sgb25seSBmb3IgdGhlIG9uZXMg dGhhdCBhcmUNCisgKiB3aGVuIHBlcmZvcm1pbmcgZXJyb3IgaGFuZGxpbmcuDQogKi8NCisjZGVm aW5lICAgICAgICBBTFRFUkFfU0RDQVJEX1JSMV9FUlJPUk1BU0sgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgXA0KKyAgICAoQUxURVJBX1NEQ0FSRF9SUjFfRVJBU0VJ TlRFUlJVUFRFRCB8IEFMVEVSQV9TRENBUkRfUlIxX0lMTEVHQUxDT01NQU5EIHwgIFwNCisgICAg QUxURVJBX1NEQ0FSRF9SUjFfQ09NTUFORENSQ0ZBSUxFRCB8IEFMVEVSQV9TRENBUkRfUlIxX0FE RFJFU1NNSVNBTElHTkVEIHxcDQorICAgIEFMVEVSQV9TRENBUkRfUlIxX0FERFJCTE9DS1JBTkdF KQ0KDQogLyoNCiAqIEFsdGhvdWdoIFNEIENhcmRzIG1heSBoYXZlIHZhcmlvdXMgc2VjdG9yIHNp emVzLCB0aGUgQWx0ZXJhIElQIENvcmUNCg0KPT09PSAvL2RlcG90L3Byb2plY3RzL2N0c3JkL2Jl cmlic2Qvc3JjL3N5cy9kZXYvYWx0ZXJhL3NkY2FyZC9hbHRlcmFfc2RjYXJkX2lvLmMjMTAgKHRl eHQra28pID09PT0NCg0KQEAgLTE4OCw3ICsxODgsNyBAQA0KICogcmVnaXN0ZXIsIGJ1dCBhbGwg Yml0cyBpdCBpZGVudGlmaWVzIGFyZSA+MTYgYml0LiAgTW9zdCBsaWtlbHksIFJSMSBpcyBhDQog KiAzMi1iaXQgcmVnaXN0ZXI/DQogKi8NCi11aW50MTZfdA0KK3N0YXRpYyB1aW50MTZfdA0KIGFs dGVyYV9zZGNhcmRfcmVhZF9ycjEoc3RydWN0IGFsdGVyYV9zZGNhcmRfc29mdGMgKnNjKQ0KIHsN Cg0KQEAgLTI4Nyw3ICsyODcsNyBAQA0KIGFsdGVyYV9zZGNhcmRfaW9fY29tcGxldGUoc3RydWN0 IGFsdGVyYV9zZGNhcmRfc29mdGMgKnNjLCB1aW50MTZfdCBhc3IpDQogew0KICAgICAgIHN0cnVj dCBiaW8gKmJwOw0KLSAgICAgICB1aW50MTZfdCBycjE7DQorICAgICAgIHVpbnQxNl90IHJyMSwg bWFzazsNCiAgICAgICBpbnQgZXJyb3I7DQoNCiAgICAgICBBTFRFUkFfU0RDQVJEX0xPQ0tfQVNT RVJUKHNjKTsNCkBAIC0yOTgsMTIgKzI5OCw0MiBAQA0KDQogICAgICAgYnAgPSBzYy0+YXNfY3Vy cmVudGJpbzsNCg0KLSAgICAgICAvKg0KLSAgICAgICAgKiBIYW5kbGUgSS9PIHJldHJpZXMgaWYg YW4gZXJyb3IgaXMgcmV0dXJuZWQgYnkgdGhlIGRldmljZS4NCisgICAgICAgLyotDQorICAgICAg ICAqIEhhbmRsZSBJL08gcmV0cmllcyBpZiBhbiBlcnJvciBpcyByZXR1cm5lZCBieSB0aGUgZGV2 aWNlLiAgVmFyaW91cw0KKyAgICAgICAgKiBxdWlya3MgaGFuZGxlZCBpbiB0aGUgcHJvY2VzczoN CisgICAgICAgICoNCisgICAgICAgICogMS4gQUxURVJBX1NEQ0FSRF9BU1JfQ01EREFUQUVSUk9S IGlzIGlnbm9yZWQgZm9yIEJJT19XUklURS4NCisgICAgICAgICogMi4gQUxURVJBX1NEQ0FSRF9S UjFfQ09NTUFORENSQ0ZBSUxFRCBpcyBpZ25vcmVkIGZvciBCSU9fUkVBRC4NCiAgICAgICAgKi8N Ci0gICAgICAgaWYgKChhc3IgJiBBTFRFUkFfU0RDQVJEX0FTUl9DTURUSU1FT1VUKSB8fCAoYnAt PmJpb19jbWQgPT0gQklPX1JFQUQNCi0gICAgICAgICAgICYmIChhc3IgJiBBTFRFUkFfU0RDQVJE X0FTUl9DTUREQVRBRVJST1IpKSkgew0KLSAgICAgICAgICAgICAgIHJyMSA9IGFsdGVyYV9zZGNh cmRfcmVhZF9ycjEoc2MpOw0KKyAgICAgICBlcnJvciA9IDA7DQorICAgICAgIHJyMSA9IGFsdGVy YV9zZGNhcmRfcmVhZF9ycjEoc2MpOw0KKyAgICAgICBzd2l0Y2ggKGJwLT5iaW9fY21kKSB7DQor ICAgICAgIGNhc2UgQklPX1JFQUQ6DQorICAgICAgICAgICAgICAgbWFzayA9IEFMVEVSQV9TRENB UkRfUlIxX0VSUk9STUFTSzsNCisgICAgICAgICAgICAgICBtYXNrICY9IH5BTFRFUkFfU0RDQVJE X1JSMV9DT01NQU5EQ1JDRkFJTEVEOw0KKyAgICAgICAgICAgICAgIGlmIChhc3IgJiBBTFRFUkFf U0RDQVJEX0FTUl9DTURUSU1FT1VUKQ0KKyAgICAgICAgICAgICAgICAgICAgICAgZXJyb3IgPSBF SU87DQorICAgICAgICAgICAgICAgZWxzZSBpZiAoKGFzciAmIEFMVEVSQV9TRENBUkRfQVNSX0NN RERBVEFFUlJPUikgJiYNCisgICAgICAgICAgICAgICAgICAgKHJyMSAmIG1hc2spKQ0KKyAgICAg ICAgICAgICAgICAgICAgICAgZXJyb3IgPSBFSU87DQorICAgICAgICAgICAgICAgZWxzZQ0KKyAg ICAgICAgICAgICAgICAgICAgICAgZXJyb3IgPSAwOw0KKyAgICAgICAgICAgICAgIGJyZWFrOw0K Kw0KKyAgICAgICBjYXNlIEJJT19XUklURToNCisgICAgICAgICAgICAgICBpZiAoYXNyICYgQUxU RVJBX1NEQ0FSRF9BU1JfQ01EVElNRU9VVCkNCisgICAgICAgICAgICAgICAgICAgICAgIGVycm9y ID0gRUlPOw0KKyAgICAgICAgICAgICAgIGVsc2UNCisgICAgICAgICAgICAgICAgICAgICAgIGVy cm9yID0gMDsNCisgICAgICAgICAgICAgICBicmVhazsNCisNCisgICAgICAgZGVmYXVsdDoNCisg ICAgICAgICAgICAgICBicmVhazsNCisgICAgICAgfQ0KKyAgICAgICBpZiAoZXJyb3IpIHsNCisg ICAgICAgICAgICAgICAvKg0KKyAgICAgICAgICAgICAgICAqIFRoaXMgYXR0ZW1wdCBleHBlcmll bmNlZCBhbiBlcnJvcjsgcG9zc2libHkgcmV0cnkuDQorICAgICAgICAgICAgICAgICovDQogICAg ICAgICAgICAgICBzYy0+YXNfcmV0cmllc2xlZnQtLTsNCiAgICAgICAgICAgICAgIGlmIChzYy0+ YXNfcmV0cmllc2xlZnQgIT0gMCkgew0KICAgICAgICAgICAgICAgICAgICAgICBzYy0+YXNfZmxh Z3MgfD0gQUxURVJBX1NEQ0FSRF9GTEFHX0lPRVJST1I7DQpAQCAtMzE2LDggKzM0NiwxMCBAQA0K ICAgICAgICAgICAgICAgICAgIChicC0+YmlvX2NtZCA9PSBCSU9fV1JJVEUgPyAiQklPX1dSSVRF IiA6ICJ1bmtub3duIiksDQogICAgICAgICAgICAgICAgICAgYnAtPmJpb19wYmxrbm8sIGJwLT5i aW9fYmNvdW50LCBhc3IsIHJyMSk7DQogICAgICAgICAgICAgICBzYy0+YXNfZmxhZ3MgJj0gfkFM VEVSQV9TRENBUkRfRkxBR19JT0VSUk9SOw0KLSAgICAgICAgICAgICAgIGVycm9yID0gRUlPOw0K ICAgICAgIH0gZWxzZSB7DQorICAgICAgICAgICAgICAgLyoNCisgICAgICAgICAgICAgICAgKiBT dWNjZXNzZnVsIEkvTyBjb21wbGV0aW9uIHBhdGguDQorICAgICAgICAgICAgICAgICovDQogICAg ICAgICAgICAgICBpZiAoc2MtPmFzX2ZsYWdzICYgQUxURVJBX1NEQ0FSRF9GTEFHX0lPRVJST1Ip IHsNCiAgICAgICAgICAgICAgICAgICAgICAgZGV2aWNlX3ByaW50ZihzYy0+YXNfZGV2LCAiJXM6 ICVzIG9wZXJhdGlvbiBibG9jayAlanUiDQogICAgICAgICAgICAgICAgICAgICAgICAgICAiIGxl bmd0aCAlanUgc3VjY2VlZGVkIGFmdGVyICVkIHJldHJpZXNcbiIsDQpAQCAtMzI3LDEwICszNTks NiBAQA0KICAgICAgICAgICAgICAgICAgICAgICAgICAgQUxURVJBX1NEQ0FSRF9SRVRSWV9MSU1J VCAtIHNjLT5hc19yZXRyaWVzbGVmdCk7DQogICAgICAgICAgICAgICAgICAgICAgIHNjLT5hc19m bGFncyAmPSB+QUxURVJBX1NEQ0FSRF9GTEFHX0lPRVJST1I7DQogICAgICAgICAgICAgICB9DQot DQotICAgICAgICAgICAgICAgLyoNCi0gICAgICAgICAgICAgICAgKiBTdWNjZXNzZnVsIEkvTyBj b21wbGV0aW9uIHBhdGguDQotICAgICAgICAgICAgICAgICovDQogICAgICAgICAgICAgICBzd2l0 Y2ggKGJwLT5iaW9fY21kKSB7DQogICAgICAgICAgICAgICBjYXNlIEJJT19SRUFEOg0KICAgICAg ICAgICAgICAgICAgICAgICBhbHRlcmFfc2RjYXJkX3JlYWRfcnh0eF9idWZmZXIoc2MsIGJwLT5i aW9fZGF0YSwNCg0KDQo=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?38688DAC-873E-40F1-B47D-CD33DF6523E3>