From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Dec 14 01:30:10 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ED20B106566B for ; Tue, 14 Dec 2010 01:30:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A677E8FC16 for ; Tue, 14 Dec 2010 01:30:10 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oBE1UAUo012337 for ; Tue, 14 Dec 2010 01:30:10 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oBE1UARL012336; Tue, 14 Dec 2010 01:30:10 GMT (envelope-from gnats) Resent-Date: Tue, 14 Dec 2010 01:30:10 GMT Resent-Message-Id: <201012140130.oBE1UARL012336@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jason Helfman Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E26A51065675 for ; Tue, 14 Dec 2010 01:22:03 +0000 (UTC) (envelope-from jhelfman@experts-exchange.com) Received: from mail.experts-exchange.com (mail.experts-exchange.com [72.29.183.251]) by mx1.freebsd.org (Postfix) with ESMTP id C14C48FC08 for ; Tue, 14 Dec 2010 01:22:03 +0000 (UTC) Received: from mail.experts-exchange.com (localhost [127.0.0.1]) by mail.experts-exchange.com (Postfix) with ESMTP id F1C4A859E6E for ; Mon, 13 Dec 2010 17:22:02 -0800 (PST) Received: from mail.experts-exchange.com ([127.0.0.1]) by mail.experts-exchange.com (mail.experts-exchange.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cRrTnatQf1km for ; Mon, 13 Dec 2010 17:22:02 -0800 (PST) Received: from experts-exchange.com (unknown [192.168.103.122]) by mail.experts-exchange.com (Postfix) with SMTP id 9C702859E6C for ; Mon, 13 Dec 2010 17:22:02 -0800 (PST) Received: (nullmailer pid 80576 invoked by uid 1001); Tue, 14 Dec 2010 01:19:00 -0000 Message-Id: <1292289540.325037.80575.nullmailer@experts-exchange.com> Date: Mon, 13 Dec 2010 17:19:00 -0800 From: Jason Helfman To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/153136: [patch] databases/postgresql84-server: allow for postgres user to be configurable X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Jason Helfman List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Dec 2010 01:30:11 -0000 >Number: 153136 >Category: ports >Synopsis: [patch] databases/postgresql84-server: allow for postgres user to be configurable >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Dec 14 01:30:10 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Jason Helfman >Release: FreeBSD 8.1-RELEASE i386 >Organization: Experts-Exchange, LLC. >Environment: System: FreeBSD eggman.experts-exchange.com 8.1-RELEASE FreeBSD 8.1-RELEASE #0: Mon Jul 19 02:55:53 UTC 2010 root@almeida.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386 >Description: Allow for postgres user to be something other than "pgsql," but pgsql should be default. >How-To-Repeat: 1. Rename the PostgreSQL OS user name with PW(8). 2. Run "/usr/local/etc/rc.d/postgresql start" 3. It will say: "su: unknown login: pgsql" >Fix: This is largely a copy of ports/113707, however, in my humble opinion, I believe this patch would be something that may be considered more of an acceptable solution. --- postgresql84-server/Makefile.orig 2010-12-13 16:03:19.000000000 -0800 +++ postgresql84-server/Makefile 2010-12-13 16:08:08.000000000 -0800 @@ -36,8 +36,9 @@ .undef GNU_CONFIGURE .endif -PGUSER= pgsql -PGGROUP= pgsql +PGUSER?= pgsql +PGGROUP?= pgsql +PGUID?= 70 LDFLAGS+= -L${LOCALBASE}/lib INCLUDES+= -I${LOCALBASE}/include @@ -281,7 +282,11 @@ done . if exists(${FILESDIR}/pkg-message${PKGNAMESUFFIX}.in) -SUB_FILES+= pkg-message${PKGNAMESUFFIX} +SUB_FILES+= pkg-install-server \ + pkg-message${PKGNAMESUFFIX} +SUB_LIST+= PGGROUP=${PGGROUP} \ + PGUSER=${PGUSER} \ + PGUID=${PGUID} PKGMESSAGE= ${WRKSRC}/pkg-message${PKGNAMESUFFIX} . endif .endif --- postgresql84-server/pkg-install-server.orig 2010-12-13 16:04:53.000000000 -0800 +++ postgresql84-server/pkg-install-server 2010-12-13 16:10:47.000000000 -0800 @@ -3,6 +3,9 @@ # $FreeBSD: ports/databases/postgresql84-server/pkg-install-server,v 1.7 2008/02/18 12:55:02 girgen Exp $ PATH=/bin:/usr/bin:/usr/sbin +PGUSER=%%PGUSER%% +PGGROUP=%%PGGROUP%% +PGUID=%%PGUID%% backupwarning() { echo " @@ -22,11 +25,11 @@ case $2 in PRE-INSTALL) backupwarning - PGUSER=${PGUSER:-pgsql} - PGGROUP=${PGGROUP:-pgsql} + PGUSER=${PGUSER:-${PGUSER}} + PGGROUP=${PGGROUP:-${PGGROUP}} DB_DIR=${PKG_PREFIX}/${PGUSER} - UID=70 - GID=70 + UID=${PGUID} + GID=${PGUID} if pw group show "${PGGROUP}" 2>/dev/null; then echo "You already have a group \"${PGGROUP}\", so I will use it." --- postgresql84-server/files/postgresql.in.orig 2010-12-13 16:03:32.000000000 -0800 +++ postgresql84-server/files/postgresql.in 2010-12-13 17:08:31.000000000 -0800 @@ -32,7 +32,7 @@ # set defaults postgresql_enable=${postgresql_enable:-"NO"} postgresql_flags=${postgresql_flags:-"-w -s -m fast"} -postgresql_user=pgsql +postgresql_user=${postgresql_user:-"%%PGUSER%%"} eval postgresql_data=${postgresql_data:-"~${postgresql_user}/data"} postgresql_class=${postgresql_class:-"default"} postgresql_initdb_flags=${postgresql_initdb_flags:-"--encoding=utf-8 --lc-collate=C"} >Release-Note: >Audit-Trail: >Unformatted: