From owner-freebsd-bugs@FreeBSD.ORG  Mon Dec 22 23:50:03 2008
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A330D1065674
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 22 Dec 2008 23:50:03 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 90CD18FC28
	for <freebsd-bugs@hub.freebsd.org>;
	Mon, 22 Dec 2008 23:50:03 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id mBMNo3IT039267
	for <freebsd-bugs@freefall.freebsd.org>; Mon, 22 Dec 2008 23:50:03 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id mBMNo3D7039264;
	Mon, 22 Dec 2008 23:50:03 GMT (envelope-from gnats)
Date: Mon, 22 Dec 2008 23:50:03 GMT
Message-Id: <200812222350.mBMNo3D7039264@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: "Garrett Cooper" <yanefbsd@gmail.com>
Cc: 
Subject: Re: bin/129814: [patch] support of per script nice(1) value in
	periodic.conf(5)
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Garrett Cooper <yanefbsd@gmail.com>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Dec 2008 23:50:03 -0000

The following reply was made to PR bin/129814; it has been noted by GNATS.

From: "Garrett Cooper" <yanefbsd@gmail.com>
To: "Artem Naluzhnyy" <tut@nhamon.com.ua>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: bin/129814: [patch] support of per script nice(1) value in periodic.conf(5)
Date: Mon, 22 Dec 2008 15:44:22 -0800

 The only issue with this is that:
 
 if [ -n "${_nice}" ]
 
 and:
 
 elif [ -n "${default_nice}" ]
 
 don't check for valid number values. I'm not sure if we'd want to
 throw in that logic or not (or if there's something else in our
 rc-scripts that automatically checks for numbers in range)...
 
 I'd ask (quickly) on hackers@ to see if the change makes sense for a
 more widespread review.
 
 Cheers,
 -Garrett