From owner-svn-src-all@freebsd.org Tue Nov 21 16:52:36 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 055DCDF3ED5 for ; Tue, 21 Nov 2017 16:52:36 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22c.google.com (mail-io0-x22c.google.com [IPv6:2607:f8b0:4001:c06::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BC47A75D05 for ; Tue, 21 Nov 2017 16:52:35 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22c.google.com with SMTP id i184so12722590ioa.0 for ; Tue, 21 Nov 2017 08:52:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=yVdmqaGtMRzq7cPp8MYRhbcFJd4tkD7xCPOBKmiHm3Q=; b=S6T+SxYaZMdH7hdzbUIQDhyOTvjtNAe9RVbY7UsftSDoAXkfP/Z3fc4K7bTie3vzLv pF49XQ6eF2EX9GERwUywfjLRDhmWeRgNesmKpg/Op+91FVamvvO6BrbwLdyMF+Nm4JfZ 35itL5EdGZHvwUSx56N8n15z+mVrSIMyf65oWHAxV52Wcj2GTx+BJWaucjn6OIRsbLAB 6EF7xJmQoFy00m1ndc9pneSRz7gvNHN40NkfvsMouBFGPgkxUZnSQJIE3QxvXt19D5Ph EuPeys9e4X54Q+ZY7CD6Y5ut/vrIDPnHQftMyji9WQxx31eG0EizQ3e/bB14e8RAaIEQ r/FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=yVdmqaGtMRzq7cPp8MYRhbcFJd4tkD7xCPOBKmiHm3Q=; b=X740X85R3oXU6citYXXCDQphQHoeY2I+vq3PpJg6Ow458wxM0idqTUdcbSpjHHHwkj V+XHaNvIk54a4YqC8a01R5bymCZMmsr+sT0tthSHvuwuNt9nWyLJCEiiZPSuCTlZ6hCc LJdd66/Npg9JvaUc1MbHw5fMLWt+/KmqPzzWEl2rSKwohKPBQpxlD3bnrcHI0T4zaMdo 78RbYWhuYEpq/08tzCEW6whEls7NdBjTs4sDaf/3XgxMF5F+1BIKDxN7IbpOp7Ip8/zc y8AJrX7Xkxw/nLT3gGu7yTsGLq/ugddEVLAbBFX1Iro8gc0I6aCqFJaZ5cUhveyqzLdO vEJQ== X-Gm-Message-State: AJaThX5GoQLwmTUE9YGat8XLu1PqNnvz6kMh1uUob1VK9htOzFkGTIIR J9cGJxAmR2MdRhnLJjCsmH+xW68+e+sxxbNbK4G2ng== X-Google-Smtp-Source: AGs4zMapCIeGFzfkgwxQnyjnMjvIxUHlH6hlFS0NaYVZG1ybJcaos7g3B6MG9lBGWANcAZG6nMPtOQdhgk25NRKJX24= X-Received: by 10.107.81.24 with SMTP id f24mr18607867iob.63.1511283154887; Tue, 21 Nov 2017 08:52:34 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.108.204 with HTTP; Tue, 21 Nov 2017 08:52:34 -0800 (PST) X-Originating-IP: [2603:300b:6:5100:c91c:5e34:ef38:d5a] In-Reply-To: <20171121233000.M2067@besplex.bde.org> References: <201711202241.vAKMfMpO008434@repo.freebsd.org> <20171121233000.M2067@besplex.bde.org> From: Warner Losh Date: Tue, 21 Nov 2017 09:52:34 -0700 X-Google-Sender-Auth: 9LCF8nLw8dKZgCi4XAUSa21TJ98 Message-ID: Subject: Re: svn commit: r326037 - head/share/mk To: Bruce Evans Cc: Warner Losh , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 16:52:36 -0000 On Tue, Nov 21, 2017 at 5:44 AM, Bruce Evans wrote: > On Mon, 20 Nov 2017, Warner Losh wrote: > > Author: imp >> Date: Mon Nov 20 22:41:22 2017 >> New Revision: 326037 >> URL: https://svnweb.freebsd.org/changeset/base/326037 >> >> Log: >> Add -mno-avx2 for clang as well as -mno-avx. We don't want either of >> them when asking for no SIMD. >> > > Is this needed. For SSE, -mno-sse implies -mno-sse[2,3,4,...] so > an multiple set of no-sse* flags are not needed (I have only checked this > for sse2). Multiple no-sse* flags are also not used. I've had reports that the EFI boot loader uses these AVX2 instructions when you set CPUTYPE=haswell. I've not independently confirmed this, as this was a few years ago. But it was an easy bug to fix. Modified: head/share/mk/bsd.cpu.mk >> ============================================================ >> ================== >> --- head/share/mk/bsd.cpu.mk Mon Nov 20 22:27:33 2017 (r326036) >> +++ head/share/mk/bsd.cpu.mk Mon Nov 20 22:41:22 2017 (r326037) >> @@ -393,7 +393,7 @@ CFLAGS += ${_CPUCFLAGS} >> # (-mfpmath= is not supported) >> # >> .if ${MACHINE_CPUARCH} == "i386" || ${MACHINE_CPUARCH} == "amd64" >> -CFLAGS_NO_SIMD.clang= -mno-avx >> +CFLAGS_NO_SIMD.clang= -mno-avx -mno-avx2 >> CFLAGS_NO_SIMD= -mno-mmx -mno-sse >> > > Nearby example of non-use for SSE. Yes. .endif >> CFLAGS_NO_SIMD += ${CFLAGS_NO_SIMD.${COMPILER_TYPE}} >> > > Testing shows that -mavx2 -mno-avx kills all AVX for clang in an example > that only generates AVX instructions (-mavx2 enabls these as a subset). I'll have to confirm. Skylake adds avx512 as well, so I'll have to check it there too... Warner