From owner-freebsd-bugs@FreeBSD.ORG Tue Apr 7 20:50:06 2009 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 607941065672 for ; Tue, 7 Apr 2009 20:50:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 2244D8FC1E for ; Tue, 7 Apr 2009 20:50:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n37Ko60C041652 for ; Tue, 7 Apr 2009 20:50:06 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n37Ko5h4041651; Tue, 7 Apr 2009 20:50:05 GMT (envelope-from gnats) Resent-Date: Tue, 7 Apr 2009 20:50:05 GMT Resent-Message-Id: <200904072050.n37Ko5h4041651@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Rafal Grodzinski Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 996B8106568E for ; Tue, 7 Apr 2009 20:45:22 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 871888FC17 for ; Tue, 7 Apr 2009 20:45:22 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n37KjMuK013259 for ; Tue, 7 Apr 2009 20:45:22 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n37KjMxj013258; Tue, 7 Apr 2009 20:45:22 GMT (envelope-from nobody) Message-Id: <200904072045.n37KjMxj013258@www.freebsd.org> Date: Tue, 7 Apr 2009 20:45:22 GMT From: Rafal Grodzinski To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: bin/133473: [patch] pkg_info throws segmentation fault if given non-existent long option X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Apr 2009 20:50:06 -0000 >Number: 133473 >Category: bin >Synopsis: [patch] pkg_info throws segmentation fault if given non-existent long option >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Apr 07 20:50:05 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Rafal Grodzinski >Release: 7.1-Release >Organization: >Environment: FreeBSD grodzix 7.1-RELEASE FreeBSD 7.1-RELEASE #0: Thu Jan 1 14:37:25 UTC 2009 root@logan.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386 >Description: pkg_info (usr.sbin/pkg_install/info) throws segmentation fault if non existent long option is provided. Array struct option longopts[] in main.c isn't ended with {NULL, 0, NULL, 0} so getopt_long doesn't know where to stop and tries to read past the last element of the array. >How-To-Repeat: pkg_info --y pkg_info --ble >Fix: Add {NULL, 0, NULL, 0} at the end of struct option longopts[] array in main.c Patch attached with submission follows: --- /usr/src/usr.sbin/pkg_install/info/main.c 2008-11-25 02:59:29.000000000 +0000 +++ main.c 2009-04-07 20:01:57.000000000 +0000 @@ -58,6 +58,7 @@ { "verbose", no_argument, NULL, 'v' }, { "version", no_argument, NULL, 'P' }, { "which", required_argument, NULL, 'W' }, + { NULL, 0, NULL, 0 }, }; int >Release-Note: >Audit-Trail: >Unformatted: