From owner-cvs-src@FreeBSD.ORG Fri Mar 5 10:12:46 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C7CE316A4D0 for ; Fri, 5 Mar 2004 10:12:46 -0800 (PST) Received: from root.org (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 6FFA043D39 for ; Fri, 5 Mar 2004 10:12:46 -0800 (PST) (envelope-from nate@root.org) Received: (qmail 30614 invoked by uid 1000); 5 Mar 2004 18:12:47 -0000 Date: Fri, 5 Mar 2004 10:12:47 -0800 (PST) From: Nate Lawson To: Alan Cox In-Reply-To: <20040305044635.57CFC16A533@hub.freebsd.org> Message-ID: <20040305101201.H30482@root.org> References: <20040305044635.57CFC16A533@hub.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: [src] cvs commit: src/sys/vm vm_contig.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Mar 2004 18:12:46 -0000 On Thu, 4 Mar 2004, Alan Cox wrote: > FreeBSD src repository > > Modified files: > sys/vm vm_contig.c > Log: > In the last revision, I introduced a physical contiguity check that is both > unnecessary and wrong. While it is necessary to verify that the page is > still free after dropping and reacquiring the free page queue lock, the > physical contiguity of the page can not change, making this check > unnecessary. This check was wrong in that it could cause an out-of-bounds > array access. > > Tested by: rwatson > > Revision Changes Path > 1.32 +1 -3 src/sys/vm/vm_contig.c Reported, tested by: marcel Initial incorrect fix: njl -Nate