From owner-svn-src-head@freebsd.org Fri Oct 2 18:55:01 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AFE94A0D1AA; Fri, 2 Oct 2015 18:55:01 +0000 (UTC) (envelope-from rpaulo@me.com) Received: from mr11p00im-asmtp001.me.com (mr11p00im-asmtp001.me.com [17.110.69.252]) (using TLSv1.2 with cipher DHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8ED44104D; Fri, 2 Oct 2015 18:55:01 +0000 (UTC) (envelope-from rpaulo@me.com) Received: from akita (c-73-162-13-215.hsd1.ca.comcast.net [73.162.13.215]) by mr11p00im-asmtp001.me.com (Oracle Communications Messaging Server 7.0.5.35.0 64bit (built Mar 31 2015)) with ESMTPSA id <0NVL00GF3TRHHX30@mr11p00im-asmtp001.me.com>; Fri, 02 Oct 2015 17:54:55 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-10-02_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 kscore.is_bulkscore=2.57571741713036e-14 compositescore=0.981618935876834 phishscore=0 kscore.is_spamscore=0 rbsscore=0.981618935876834 recipient_to_sender_totalscore=0 spamscore=0 urlsuspectscore=0.981618935876834 adultscore=0 kscore.compositescore=0 circleOfTrustscore=0 suspectscore=0 recipient_domain_to_sender_totalscore=0 bulkscore=0 recipient_domain_to_sender_domain_totalscore=0 recipient_to_sender_domain_totalscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1412110000 definitions=main-1510020225 Message-id: <1443808493.13078.11.camel@me.com> Subject: Re: svn commit: r288362 - head/sys/cddl/dev/sdt From: Rui Paulo To: Andriy Gapon , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Fri, 02 Oct 2015 10:54:53 -0700 In-reply-to: <201509291158.t8TBwLd1052484@repo.freebsd.org> References: <201509291158.t8TBwLd1052484@repo.freebsd.org> Content-type: text/plain; charset=UTF-8 X-Mailer: Evolution 3.16.5-1 MIME-version: 1.0 Content-transfer-encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Oct 2015 18:55:01 -0000 On Tue, 2015-09-29 at 11:58 +0000, Andriy Gapon wrote: > Author: avg > Date: Tue Sep 29 11:58:21 2015 > New Revision: 288362 > URL: https://svnweb.freebsd.org/changeset/base/288362 > > Log: > sdt: start checking version field when parsing probe definitions > > This is an extra safety measure. > > MFC after: 21 days > > Modified: > head/sys/cddl/dev/sdt/sdt.c > > Modified: head/sys/cddl/dev/sdt/sdt.c > ===================================================================== > ========= > --- head/sys/cddl/dev/sdt/sdt.c Tue Sep 29 11:55:26 2015 > (r288361) > +++ head/sys/cddl/dev/sdt/sdt.c Tue Sep 29 11:58:21 2015 > (r288362) > @@ -141,6 +141,12 @@ sdt_create_probe(struct sdt_probe *probe > char *to; > size_t len; > > + if (probe->version != (int)sizeof(*probe)) { > + printf("ignoring probe %p, version %u expected > %u\n", > + probe, probe->version, (int)sizeof(*probe)); > + return; > + } > + > Not picking on your change, but this version management sounds like a bad idea to me... -- Rui Paulo