From owner-cvs-all@FreeBSD.ORG  Tue Dec 30 08:30:22 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id A41D616A4CE; Tue, 30 Dec 2003 08:30:22 -0800 (PST)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8EE9D43D39; Tue, 30 Dec 2003 08:30:20 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246])
	by mailman.zeta.org.au (8.9.3p2/8.8.7) with ESMTP id DAA04015;
	Wed, 31 Dec 2003 03:30:13 +1100
Date: Wed, 31 Dec 2003 03:30:13 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Dag-Erling =?iso-8859-1?q?Sm=F8rgrav?= <des@des.no>
In-Reply-To: <xzpznda8t0m.fsf@dwp.des.no>
Message-ID: <20031231032019.G1268@gamplex.bde.org>
References: <200312271354.hBRDs3CN092828@repoman.freebsd.org>
 <xzpznda8t0m.fsf@dwp.des.no>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=X-UNKNOWN
Content-Transfer-Encoding: QUOTED-PRINTABLE
cc: cvs-src@freebsd.org
cc: src-committers@freebsd.org
cc: Bruce Evans <bde@freebsd.org>
cc: cvs-all@freebsd.org
Subject: Re: cvs commit: src/sbin/fsck fsutil.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Dec 2003 16:30:22 -0000

On Tue, 30 Dec 2003, Dag-Erling [iso-8859-1] Sm=F8rgrav wrote:

> Bruce Evans <bde@FreeBSD.org> writes:
> >   Declare perror().  We define and use a home made version of perror(3)
> >   that can't simply be removed (although it has the same interface as
> >   perror(3)) since it is very different (it prints on stdout, doesn't
> >   always print the program name, and sometimes exits).  Declare it to
> >   get a reminder of this brokenness when WARNS is increased enough.
>
> Why not just rename it to not_perror()?

Because it should be fixed better.  fsck_ffs gets by without any
perror() function, and fsck_ffs's other error reporting functions are
subtly different.  I haven't decided whether fsck_ffs should be more
like fsck_msdosfs or vice versa.

Bruce