From owner-svn-src-head@freebsd.org Fri Apr 20 18:57:28 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 18AC7F91F70; Fri, 20 Apr 2018 18:57:28 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it0-f44.google.com (mail-it0-f44.google.com [209.85.214.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AB7BF7F629; Fri, 20 Apr 2018 18:57:27 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it0-f44.google.com with SMTP id h143-v6so3766745ita.4; Fri, 20 Apr 2018 11:57:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=slrl8SFk6amIK+OD6cMKVNugV26ixpS6hCGrL2jGXhg=; b=H+H2li7wGbJTx7NN3wD4Txdag8V+Bunyq07xNbDbPtbuuQ0RKYI6hmRlzUW0HIyoU7 2jVDIw2VOZx9aXBWQb/ZKv8QVMlpDwUXEvjto2MrR5fsOQ6nJ4lK3+7AK0RDLHNKq1Ty jOpGU9Ay6I8iORppDZ6EEL1QebnVsdrcKfMmtukDKBJG+8KZow7CD/BcXjCk0LGKMUUr JnbSpOZtT9cAIuhFhTx7FhqlkqGWg0OiAMnEuMSF4fLOeBT9XabbvA5+Qs/BGNA1V6UQ srAxL2FyKn4R6mMlSVS9O5eg5qScBmXzB8Q5ioP1Nn3o1pPGoZSltvuC5aipLs8RL2LX +8iw== X-Gm-Message-State: ALQs6tB9bfrYEiMclzKMxEcAkPmJGMUDe8t9iMQBPP1147Lr7sdNa30n 79Onyiw/7FpTfubvdiK4mQvbNaKT X-Google-Smtp-Source: AIpwx4++Uj2EfRDjstJyjjSWtenMi+eY44R/UXlgTYHkjHDyI5hF+shGcaqKvrM07GHsNKiBPzkuBw== X-Received: by 2002:a24:27c9:: with SMTP id g192-v6mr4238232ita.112.1524250218966; Fri, 20 Apr 2018 11:50:18 -0700 (PDT) Received: from mail-it0-f51.google.com (mail-it0-f51.google.com. [209.85.214.51]) by smtp.gmail.com with ESMTPSA id b3-v6sm3255068iob.55.2018.04.20.11.50.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Apr 2018 11:50:18 -0700 (PDT) Received: by mail-it0-f51.google.com with SMTP id m134-v6so3754081itb.3; Fri, 20 Apr 2018 11:50:18 -0700 (PDT) X-Received: by 2002:a24:4090:: with SMTP id n138-v6mr4284583ita.135.1524250218541; Fri, 20 Apr 2018 11:50:18 -0700 (PDT) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 2002:a02:224d:0:0:0:0:0 with HTTP; Fri, 20 Apr 2018 11:50:18 -0700 (PDT) In-Reply-To: <201804201138.w3KBcTou070611@repo.freebsd.org> References: <201804201138.w3KBcTou070611@repo.freebsd.org> From: Conrad Meyer Date: Fri, 20 Apr 2018 11:50:18 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r332813 - head/sys/fs/nfsclient To: Rick Macklem Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Apr 2018 18:57:28 -0000 On Fri, Apr 20, 2018 at 4:38 AM, Rick Macklem wrote: > Author: rmacklem > Date: Fri Apr 20 11:38:29 2018 > New Revision: 332813 > URL: https://svnweb.freebsd.org/changeset/base/332813 > > Log: > Fix use of pointer after being set NULL. > > Using a pointer after setting it NULL is probably not a good plan. > Spotted by inspection during changes for Flexible File Layout Ioerr handling. > This code path obviously isn't normally executed. This is definitely the kind of thing that Coverity can catch. I would strongly encourage you to take a look at the Coverity scan output for nfsclient. There are a bunch of reports, many of which I have confirmed are valid. Best, Conrad