From owner-freebsd-bugs@FreeBSD.ORG  Tue Dec 16 16:00:15 2008
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EFCD3106567A
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 16 Dec 2008 16:00:15 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id DD3CD8FC1B
	for <freebsd-bugs@hub.freebsd.org>;
	Tue, 16 Dec 2008 16:00:15 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id mBGG09il088566
	for <freebsd-bugs@freefall.freebsd.org>; Tue, 16 Dec 2008 16:00:09 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id mBGG09q1088559;
	Tue, 16 Dec 2008 16:00:09 GMT (envelope-from gnats)
Date: Tue, 16 Dec 2008 16:00:09 GMT
Message-Id: <200812161600.mBGG09q1088559@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Jaakko Heinonen <jh@saunalahti.fi>
Cc: 
Subject: Re: bin/129620: Incorrect bzip2 behavior
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Jaakko Heinonen <jh@saunalahti.fi>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Dec 2008 16:00:16 -0000

The following reply was made to PR bin/129620; it has been noted by GNATS.

From: Jaakko Heinonen <jh@saunalahti.fi>
To: Alex Keda <admin@lissyara.su>
Cc: bug-followup@FreeBSD.org
Subject: Re: bin/129620: Incorrect bzip2 behavior
Date: Tue, 16 Dec 2008 17:59:13 +0200

 On 2008-12-13, Alex Keda wrote:
 > acer# bzip2 --best --keep vmcore.9
 > bzip2: Input file vmcore.9 has 1 other link.
 > acer# bzip2 --best --keep --force vmcore.9
 > acer# ll | grep core
 > -rw-------  2 root  wheel   206M 13 &#1076;&#1077;&#1082; 22:41 vmcore.9
 > -rw-------  1 root  wheel    15M 13 &#1076;&#1077;&#1082; 22:41 vmcore.9.bz2
 > acer#   
 > ================
 > I use '--keep' option. I think, not need check num links in this situation...
 
 This patch should do it:
 
 %%%
 Index: contrib/bzip2/bzip2.c
 ===================================================================
 --- contrib/bzip2/bzip2.c	(revision 186035)
 +++ contrib/bzip2/bzip2.c	(working copy)
 @@ -1208,7 +1208,7 @@ void compress ( Char *name )
  	 return;
        }
     }
 -   if ( srcMode == SM_F2F && !forceOverwrite &&
 +   if ( srcMode == SM_F2F && !forceOverwrite && !keepInputFiles &&
          (n=countHardLinks ( inName )) > 0) {
        fprintf ( stderr, "%s: Input file %s has %d other link%s.\n",
                  progName, inName, n, n > 1 ? "s" : "" );
 %%%
 
 Could you report this to bzip2 upstream? Looks like this behavior
 exists in the latest upstream version.
 
 -- 
 Jaakko