Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 3 Aug 2012 20:24:17 +0000 (UTC)
From:      Jim Harris <jimharris@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r239021 - head/sys/geom/virstor
Message-ID:  <201208032024.q73KOHCE065067@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jimharris
Date: Fri Aug  3 20:24:16 2012
New Revision: 239021
URL: http://svn.freebsd.org/changeset/base/239021

Log:
  In virstor_ctl_stop(), check for a valid softc before trying to update
   metadata.
  
  Sponsored by:		Intel
  Reported and tested by:	Marcelo Gondim <gondim at bsdinfo dot com dot br>
  PR:			kern/170199
  MFC after:		3 days

Modified:
  head/sys/geom/virstor/g_virstor.c

Modified: head/sys/geom/virstor/g_virstor.c
==============================================================================
--- head/sys/geom/virstor/g_virstor.c	Fri Aug  3 18:40:44 2012	(r239020)
+++ head/sys/geom/virstor/g_virstor.c	Fri Aug  3 20:24:16 2012	(r239021)
@@ -235,6 +235,12 @@ virstor_ctl_stop(struct gctl_req *req, s
 			return;
 		}
 		sc = virstor_find_geom(cp, name);
+		if (sc == NULL) {
+			gctl_error(req, "Don't know anything about '%s'", name);
+			g_topology_unlock();
+			return;
+		}
+
 		LOG_MSG(LVL_INFO, "Stopping %s by the userland command",
 		    sc->geom->name);
 		update_metadata(sc);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201208032024.q73KOHCE065067>