From owner-cvs-src@FreeBSD.ORG Sat Mar 13 02:25:32 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 218E516A4CE; Sat, 13 Mar 2004 02:25:32 -0800 (PST) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id AA98743D2D; Sat, 13 Mar 2004 02:25:30 -0800 (PST) (envelope-from ru@ip.net.ua) Received: from heffalump.office.ipnet (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.10/8.12.9) with ESMTP id i2DATNee076872 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 13 Mar 2004 12:29:25 +0200 (EET) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.office.ipnet (8.12.11/8.12.11) id i2DAPLpu033810; Sat, 13 Mar 2004 12:25:21 +0200 (EET) (envelope-from ru) Date: Sat, 13 Mar 2004 12:25:20 +0200 From: Ruslan Ermilov To: Alexander Leidinger Message-ID: <20040313102520.GA33766@ip.net.ua> References: <200403122136.i2CLaCm9096276@repoman.freebsd.org> <20040312215649.GA4588@ip.net.ua> <20040313105719.5e4e8765@Magellan.Leidinger.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="G4iJoqBmSsgzjUCe" Content-Disposition: inline In-Reply-To: <20040313105719.5e4e8765@Magellan.Leidinger.net> User-Agent: Mutt/1.5.6i X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG cc: Tom Rhodes Subject: Re: cvs commit: src/share/mk bsd.cpu.mk bsd.dep.mk bsd.lib.mk bsd.sys.mk src/sys/conf files kern.mk kern.pre.mk kmod.mk src/sys/dev/aic7xxx/aicasm Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Mar 2004 10:25:32 -0000 --G4iJoqBmSsgzjUCe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 13, 2004 at 10:57:19AM +0100, Alexander Leidinger wrote: > On Fri, 12 Mar 2004 23:56:49 +0200 > Ruslan Ermilov wrote: >=20 > > > Index: src/share/mk/bsd.lib.mk > > > diff -u src/share/mk/bsd.lib.mk:1.156 src/share/mk/bsd.lib.mk:1.157 > > > --- src/share/mk/bsd.lib.mk:1.156 Tue Jan 27 15:22:15 2004 > > > +++ src/share/mk/bsd.lib.mk Fri Mar 12 13:36:12 2004 > > [...] > > > +.c.o: > > > + ${CC} ${CFLAGS} -c ${.IMPSRC} -o ${.TARGET} > > > + > > >=20 > > Please revert the addition of this, it's bogus and duplicated > > what's already in sys.mk. >=20 > Ooops... sorry. I think this bogus change crept in at the time you moved > this part to sys.mk (at least I think you did something like this, and I > forgot to review your change entirely). >=20 OK. Tom will take care of this. > > > -.endif !defined(INTERNALLIB) > > > +.endif #!defined(INTERNALLIB) > > > =20 > > Please revert this. >=20 > Why? .endif doesn't take an argument and it serves as a comment. So why > not make it explicit? I would agree with adding a space after the > comment sign, but I don't understand why it should be reverted. >=20 Because it has nothing to do with ICC support. Because other places in share/mk spell it like this. Because I prefer it this way. ;) Cheers, --=20 Ruslan Ermilov FreeBSD committer ru@FreeBSD.org --G4iJoqBmSsgzjUCe Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAUuGQUkv4P6juNwoRAjxyAKCEhgAPibH0i7+hyQA8+LlaQ6ZzoACfdX7b qyps7aeAO8R67pSN0LS87y8= =9Ow8 -----END PGP SIGNATURE----- --G4iJoqBmSsgzjUCe--