From owner-svn-src-head@freebsd.org Wed Sep 23 06:25:46 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 26749A06E79; Wed, 23 Sep 2015 06:25:46 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wi0-x22f.google.com (mail-wi0-x22f.google.com [IPv6:2a00:1450:400c:c05::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B2A3C1FE4; Wed, 23 Sep 2015 06:25:45 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by wicgb1 with SMTP id gb1so190167130wic.1; Tue, 22 Sep 2015 23:25:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=BG44jH0wwRyDGhx8IzyE2aHgf7QC92gzXy4/nYbBaL0=; b=AjYbGSBmo3pL0hhs8n6++beOA2vhhMPbhNU8xkj0xNqAFp3FLGbk5t7BiT51v+BQOk sGT7z8JFTPKyrHOUxW/as6NaMYZRWJ4NSpKOq9QpPNcg+PrEB0qYMALxFSKBnrI2avGl pGt4j5YEsjdeoMcUo4NuKzbuXz8lBxCrkerV/GuUWd+g3AfrUwbRYzBjHVut65hvWPL2 upj2DXPi2s6Dpab3NTMADHrsP1XGx4A3HBuGUVlAj5kEBKUa17WP5dOLcGXm5/CxJIE+ 6ujb7mjqQWB7UdN9eJEqfaf/jfc0YHmbtzj51nblZHPd3CUq4RVuXyPg1fX8Je4ZHw9u vyvg== X-Received: by 10.180.182.84 with SMTP id ec20mr2011232wic.42.1442989543923; Tue, 22 Sep 2015 23:25:43 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id fs9sm6776838wic.24.2015.09.22.23.25.42 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Sep 2015 23:25:43 -0700 (PDT) Sender: Baptiste Daroussin Date: Wed, 23 Sep 2015 08:25:41 +0200 From: Baptiste Daroussin To: Bryan Drewery Cc: Warner Losh , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r286995 - head/share/mk Message-ID: <20150923062541.GH16800@ivaldir.etoilebsd.net> References: <201508211515.t7LFFM0U028322@repo.freebsd.org> <56023395.2080904@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="y0Ed1hDcWxc3B7cn" Content-Disposition: inline In-Reply-To: <56023395.2080904@FreeBSD.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Sep 2015 06:25:46 -0000 --y0Ed1hDcWxc3B7cn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 22, 2015 at 10:07:33PM -0700, Bryan Drewery wrote: > On 8/21/15 8:15 AM, Warner Losh wrote: > > Author: imp > > Date: Fri Aug 21 15:15:22 2015 > > New Revision: 286995 > > URL: https://svnweb.freebsd.org/changeset/base/286995 > >=20 > > Log: > > Document bsd.progs.mk, including its status as being strongly > > discouraged and that it will be going away as soon as is practicable. > >=20 > > Modified: > > head/share/mk/bsd.README >=20 > I find this functionality irreplaceable for simplicity. The alternative > is more Makefiles for simple extra progs. Granted it has meta mode > dirdeps issues but I think that is acceptable as there are other ways to > address that. >=20 > Where is this deprecation coming from? Is it just due to bapt's > in-progress (but not working) patch at https://reviews.freebsd.org/D3444 > to remove bsd.progs.mk in place of PROGS in bsd.prog.mk? >=20 > I would like to document PROGS properly. I had no idea how it worked > until reading over it tonight. If the plan wasn't to remove PROGS itself > I will do so. >=20 This is the exact opposite. the review comes from the fact that bsd.progs.mk is broken.and has not be f= ixed for a while. The brokenness comes from the fact it is including magically bsd.prog.mk multiple times, the easiy to see brokenness is the fact that everything defining FILES/SCRIPTS and other magic macros that bsd.prog.mk a= ccept via it multiple inputs will be reinstalled multiple times, one can fix thos= e by exhaustively adding overwrites of every single macros, but hat would be rea= lly tedious each time one of the thing included in bsd.prog.mk get modified or = added You can easily see that for all the bsd.tests.mk. While I do really like the fonctionnality it is very complicticated to get = it working. My work in progress version is eaily fixable by adding: https://lists.freebsd.org/pipermail/freebsd-arch/2003-June/000906.html And extending the above for LDFLAGS and CXXFLAGS. Which had been rejected in the past multiple times :( The subject came back again https://lists.freebsd.org/pipermail/freebsd-arch/2010-September/010613.html I think D3444 would be a good excuse to bring back the idea of perfiles spe= cific FLAGS. But I didn't want to wake up dead subject noone agreed on. Best regards, Bapt --y0Ed1hDcWxc3B7cn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlYCReUACgkQ8kTtMUmk6ExP8gCggOaXf+BbdsVaLGO6Qd70kFAL PZkAn0IoWKxxE80/2qDf8L6Jn3bunAcz =uGdF -----END PGP SIGNATURE----- --y0Ed1hDcWxc3B7cn--