From owner-freebsd-current@FreeBSD.ORG Mon Dec 18 17:11:14 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 42BC716A403; Mon, 18 Dec 2006 17:11:14 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (grnl-static-02-0046.dsl.iowatelecom.net [69.66.56.110]) by mx1.FreeBSD.org (Postfix) with ESMTP id D29B943CA3; Mon, 18 Dec 2006 17:11:06 +0000 (GMT) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.13.8/8.13.8) with ESMTP id kBIGaDqb086360; Mon, 18 Dec 2006 10:36:13 -0600 (CST) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.13.8/8.13.8/Submit) id kBIGaDij086359; Mon, 18 Dec 2006 10:36:13 -0600 (CST) (envelope-from brooks) Date: Mon, 18 Dec 2006 10:36:13 -0600 From: Brooks Davis To: Coleman Kane Message-ID: <20061218163613.GA86127@lor.one-eyed-alien.net> References: <20061218153906.GA6910@ramen.coleyandcheryl> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wRRV7LY7NUeQGEoC" Content-Disposition: inline In-Reply-To: <20061218153906.GA6910@ramen.coleyandcheryl> User-Agent: Mutt/1.5.11 Cc: freebsd-current@freebsd.org Subject: Re: UFS_GJOURNAL and ufs.ko X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Dec 2006 17:11:14 -0000 --wRRV7LY7NUeQGEoC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 18, 2006 at 03:39:06PM +0000, Coleman Kane wrote: > Hello, >=20 > I have noticed (since adding UFS journal support) that the > UFS_GJOURNAL option hasn't been added to the ufs.ko kernel > module. I've been using this (out of an effort to test as > much as possible as KLDs) and every time I upgrade my kernel > I must manually add -DUFS_GJOURNAL to the CFLAGS line in > its Makefile. >=20 > Is there any specific reason why this can't be committed? > So far, my experience with GJOURNAL has been great testing > it both with journal+fs on the same device as well as on > two seperate devices. >=20 > It looks like an oversight to me, but I don't want to jump > the gun on it if there is some reasonable argument to keep > it out "by default". UFS_GJOURNAL is not enabled in GENERIC yet so it should not be enabled in the module. At this time more review is needed before it can be enabled by default (believe Kirk has been convinced to perform some review). While Pawel's work looks good we need to be very, very careful with UFS. We can't afford to have anything go wrong with our main (essentially only) file system. -- Brooks --wRRV7LY7NUeQGEoC Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFFhsN8XY6L6fI4GtQRAn0QAJ9dGBgDs6l5QwfYmUlsh5b8PlV6CQCgkPHT i9DsIaS47+eNbJZIP14C7b4= =HZEX -----END PGP SIGNATURE----- --wRRV7LY7NUeQGEoC--