From owner-freebsd-current Sat Jun 8 7:44:52 2002 Delivered-To: freebsd-current@freebsd.org Received: from critter.freebsd.dk (port757.uc1-esp.isdn-lan.cybercity.dk [212.242.98.245]) by hub.freebsd.org (Postfix) with ESMTP id C86C137B405; Sat, 8 Jun 2002 07:44:48 -0700 (PDT) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.3/8.12.2) with ESMTP id g58EhRHL001667; Sat, 8 Jun 2002 16:43:27 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Brooks Davis Cc: Bruce Evans , "David O'Brien" , current@FreeBSD.ORG Subject: Re: dump (via amanda) causing panics In-Reply-To: Your message of "Fri, 07 Jun 2002 23:26:56 PDT." <20020607232656.B1469@Odin.AC.HMC.Edu> Date: Sat, 08 Jun 2002 16:43:27 +0200 Message-ID: <1666.1023547407@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20020607232656.B1469@Odin.AC.HMC.Edu>, Brooks Davis writes: >> I saw similarly bogus sector (block) numbers when I first debugged this >> problem. They were caused by missing prototypes. 32-bit block numbers >> were passed to unprototyped functions that expected daddr_t block numbers. >> When daddr_t was changed to 64 bits, there was garbage in the top 32 bits. >>=20 >> dump doesn't compile cleanly at a high WARNS level, so now would be a good >> time to WARNSify it. > >That sounds like a good idea. If someone else doesn't get there first, >I'll take a look at that soon. If nothing else, there's the plane trip >down to SFO for USENIX. Please, if you do so, do it relative to the UFS2 patch, there is little point in making it harder for both yourself and Kirk than absolutely necessary... -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message