From owner-freebsd-stable@FreeBSD.ORG Tue May 18 19:45:01 2004 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 60F7316A4CE for ; Tue, 18 May 2004 19:45:01 -0700 (PDT) Received: from alcanet.com.au (mail2.alcanet.com.au [203.62.196.17]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9C50943D5A for ; Tue, 18 May 2004 19:44:57 -0700 (PDT) (envelope-from peter.jeremy@alcatel.com.au) Received: from sydsmtp02.alcatel.com.au (IDENT:root@localhost.localdomain [127.0.0.1])i4J00liL020085; Wed, 19 May 2004 10:00:48 +1000 Received: from gsmx07.alcatel.com.au ([139.188.20.247]) by sydsmtp02.alcatel.com.au (Lotus Domino Release 5.0.12) with ESMTP id 2004051910004639:20015 ; Wed, 19 May 2004 10:00:46 +1000 Received: from gsmx07.alcatel.com.au (localhost [127.0.0.1]) i4J00kmZ079165; Wed, 19 May 2004 10:00:46 +1000 (EST) (envelope-from peter.jeremy@alcatel.com.au) Received: (from pjeremy@localhost) by gsmx07.alcatel.com.au (8.12.9p2/8.12.9/Submit) id i4J00iKs079164; Wed, 19 May 2004 10:00:44 +1000 (EST) (envelope-from peter.jeremy@alcatel.com.au) Date: Wed, 19 May 2004 10:00:43 +1000 From: Peter Jeremy To: Lefteris Tsintjelis Message-ID: <20040519000043.GA79139@gsmx07.alcatel.com.au> Mail-Followup-To: Lefteris Tsintjelis , stable@freebsd.org References: <40A0C3FC.2CDCA39D@ene.asda.gr> <20040511211714.GO95736@gsmx07.alcatel.com.au> <40A2E741.40ABFD0E@ene.asda.gr> Mime-Version: 1.0 In-Reply-To: <40A2E741.40ABFD0E@ene.asda.gr> User-Agent: Mutt/1.4.2i X-MIMETrack: Itemize by SMTP Server on SYDSMTP02/AlcatelAustralia(Release 5.0.12 |February 13, 2003) at 19/05/2004 10:00:46 AM,|February 13, 2003) at 19/05/2004 10:00:48 AM, Serialize complete at 19/05/2004 10:00:48 AM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline cc: stable@freebsd.org Subject: Re: Digiboard PCI Xem driver X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 May 2004 02:45:01 -0000 On 2004-May-13 06:10:57 +0300, Lefteris Tsintjelis wrote: >Peter Jeremy wrote: > >> "struct thread"s back to "struct proc", fix the cdevsw initialisation >> and change the kld load path). If you look at the digi.c source just after it was imported, the cdevsw initialisation is almost correct for 4.x (the last three entries should be "D_TTY | D_KQFILTER, -1, ttykqfilter" but one is missing from memory). >digi.o: In function `digi_loadmoduledata': >digi.o(.text+0x19bf): undefined reference to `linker_reference_module' Look in an old version of digi.c (cut-and-paste so beware whitespace): @@ -1027,17 +1081,18 @@ KASSERT(sc->link.data == NULL, ("Uninitialised LINK variable")); KASSERT(sc->module != NULL, ("Uninitialised module name")); + /*- + * XXX: It'd be nice to have something like linker_search_path() + * here. For the moment we hardcode things - the comments + * in linker_load_module() before the call to + * linker_search_path() suggests that ``there will be a + * system...''. + */ modlen = strlen(sc->module); - modfile = malloc(modlen + 6, M_TEMP, M_WAITOK); - snprintf(modfile, modlen + 6, "digi_%s", sc->module); - if ((res = linker_reference_module(modfile, NULL, &lf)) != 0) { - if (res == ENOENT && rootdev == NODEV) - printf("%s: Failed to autoload module: No filesystem\n", - modfile); - else - printf("%s: Failed %d to autoload module\n", modfile, - res); - } + modfile = malloc(modlen+18, M_TEMP, M_WAITOK); + snprintf(modfile, modlen+18, "/modules/digi_%s.ko", sc->module); + if ((res = linker_load_file(modfile, &lf)) != 0) + printf("%s: Failed %d to load module\n", modfile, res); free(modfile, M_TEMP); if (res != 0) return (res); >> Unfortunately, no-one seems interested in officially back-porting it >> to -stable - and I can't see it happening at all now. > >Back porting it, seems pretty simple and straight forward... The 4.x branch is now very close to being dead and it would be difficult to justify the effort now. -- Peter Jeremy