Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 26 Jul 2015 16:36:26 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 200791] ftp/vsftpd-ext : update freebsd9.3 complie fail
Message-ID:  <bug-200791-13-T3XvdAN28k@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-200791-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-200791-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200791

Jason Unovitch <jason.unovitch@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jason.unovitch@gmail.com

--- Comment #1 from Jason Unovitch <jason.unovitch@gmail.com> ---
Created attachment 159243
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=159243&action=edit
vsftp_buildfix_revised.patch

Xu,
I've attached a revised patch the does a slight rework of your original
suggestion that allows using /usr/bin/clang if it exists.  I've also gone ahead
and fixed several other portlint issues.

Summary:
- Force clang on FreeBSD < 10.0 to resolve 9.x i386 build issues
- Modernize USES with tar:tgz
- Rely on USERS/GROUPS; remove pkg-install/pkg deinstall scripts
- Remove direct chmod usage
- Regen patch to pet portlint

PR:             200791
Submitted by:   Xu Jing (maintainer - original patch)
MFH:            2015Q3

Details:

- Force clang on FreeBSD < 10.0 to resolve 9.x i386 build issues

I made one small change to the maintainer's submission in that /usr/bin/clang
is used if it exists.  Otherwise as originally written lang/clang33 will be
used.  This also resolves these two portlint issues:

FATAL: Makefile: extra item "BROKEN_FreeBSD_9_i386" placed in the LICENSE
section.
WARN: Makefile: "LICENSE" has to appear earlier.

- Modernize USES with tar:tgz

Resolves the following portlint issue:

WARN: Makefile: EXTRACT_SUFX is ".tgz". Please use USES=tar:tgz instead.

- Rely on USERS/GROUPS; remove pkg-install/pkg deinstall scripts

Justification is self explanatory.  ftp/vsftpd removed the standalone scripts
some time ago and pkg can be seen doing this on install.

===> Creating users and/or groups.
Using existing group 'ftp'.
Using existing user 'ftp'.

This also indirectly resolves the following portlint issue:

WARN: /usr/ports/ftp/vsftpd-ext/pkg-install: possible use of absolute pathname
"/var/ftp".

- Remove direct chmod usage

I'll attach a supplemental log that permissions of all the /usr/local/share
files are 644 no matter what.  If needed the pkg-plist version can be used
instead but there is no justification to do so as the default is covering it.
Resolves this portlint:

WARN: Makefile: [118]: possible use of "${CHMOD}" found. Use
@(owner,group,mode) syntax or @owner/@group operators in pkg-plist instead.


- Regen patch to pet portlint

Resolves this:

WARN: /usr/ports/ftp/vsftpd-ext/files/patch-utility: patch was not generated
using ``make makepatch''.  It is recommended to use ``make makepatch'' to
ensure proper patch format.




Other Issues:

I did not address this on the grounds that it has been a long existing port and
I'm not sure the best way to ensure this doesn't break anything.

WARN: Makefile: using hyphen in PORTNAME. consider using PKGNAMEPREFIX and/or
PKGNAMESUFFIX.

I did not address this as the port is building as intended with and without the
options along with ftp/vsftpd is still using the same code at this time.

WARN: Makefile: you should only use ".if ${PORT_OPTIONS:MDOCS}" to wrap
installation of files into /usr/local/share/doc if the collection of files is
large and it takes considerable time to copy.

-- 
You are receiving this mail because:
You are the assignee for the bug.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-200791-13-T3XvdAN28k>