Date: Tue, 6 Feb 2024 14:23:10 -0700 From: Warner Losh <imp@bsdimp.com> To: Kristof Provost <kp@freebsd.org> Cc: Mateusz Guzik <mjguzik@gmail.com>, Gleb Smirnoff <glebius@freebsd.org>, src-committers <src-committers@freebsd.org>, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Igor Ostapenko <pm@igoro.pro>, Kajetan Staszkiewicz <vegeta@tuxpowered.net> Subject: Re: git: 6d4a140acfdf - main - pf: Ensure that st->kif is obtained in a way which respects the r->rpool->mtx mutex Message-ID: <CANCZdfoMdw1_swQr=_T3sXBz%2BikjUfFEr4HN-sChEmkxL1usiQ@mail.gmail.com> In-Reply-To: <0A170E1B-4684-470F-9B4B-65B166191CEE@FreeBSD.org> References: <202402052119.415LJKSN037380@gitrepo.freebsd.org> <ZcGTPZLQuDNyhYrm@cell.glebi.us> <B337C14A-EE7C-4209-A416-C1674BCAD903@FreeBSD.org> <CAGudoHG3emJ5SHMYu9%2BivU=QEScpc5QU9zkfN8U47NeL2LAz6A@mail.gmail.com> <CANCZdfqG0%2BzNaTOA9A2%2BnPb3yR7_oxUoPsynZg67=0JPy2SDBA@mail.gmail.com> <0A170E1B-4684-470F-9B4B-65B166191CEE@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Tue, Feb 6, 2024 at 9:27 AM Kristof Provost <kp@freebsd.org> wrote: > > I need to land my -c flag that automates git arc patch more... > > If that does what I think it does (i.e. commit the patch locally, rather > than just staging it) you do indeed need to land that. It’ll be very > helpful. > Oh, I already landed it in 787cb30d20ac2031283c6dc2ec829f190997e581. And it does do what you think: It will use the phabricator APIs to scrape as much information as it can out of it (author, etc) and commit it so you can not have to worry about cut and pasting the wrong thing, retyping commit messages, etc. Give it a try, and let me know what screws up. Just add '-c' where you'd use 'git arc patch' today. I have some doodles for pulling the entire chain down as well, but got side tracked into just getting arc (archanist) to do that for me and see what the quality of the results are and I never was happy with the couple of patch trains that I tried. Warner [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Feb 6, 2024 at 9:27 AM Kristof Provost <<a href="mailto:kp@freebsd.org">kp@freebsd.org</a>> wrote:</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> > I need to land my -c flag that automates git arc patch more...<br> <br> If that does what I think it does (i.e. commit the patch locally, rather than just staging it) you do indeed need to land that. It’ll be very helpful.<br></blockquote><div><br></div><div>Oh, I already landed it in 787cb30d20ac2031283c6dc2ec829f190997e581. And it does do what you think: It will use the phabricator APIs to scrape as much information as it can out of it (author, etc) and commit it so you can not have to worry about cut and pasting the wrong thing, retyping commit messages, etc.</div><div><br></div><div>Give it a try, and let me know what screws up. Just add '-c' where you'd use 'git arc patch' today. I have some doodles for pulling the entire chain down as well, but got side tracked into just getting arc (archanist) to do that for me and see what the quality of the results are and I never was happy with the couple of patch trains that I tried.</div><div><br></div><div>Warner</div></div></div>help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoMdw1_swQr=_T3sXBz%2BikjUfFEr4HN-sChEmkxL1usiQ>