From owner-svn-src-all@FreeBSD.ORG Thu Dec 11 09:05:52 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B4AD4E51; Thu, 11 Dec 2014 09:05:52 +0000 (UTC) Received: from mail-pa0-x230.google.com (mail-pa0-x230.google.com [IPv6:2607:f8b0:400e:c03::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8031A223; Thu, 11 Dec 2014 09:05:52 +0000 (UTC) Received: by mail-pa0-f48.google.com with SMTP id rd3so4669096pab.21 for ; Thu, 11 Dec 2014 01:05:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=geF746n2Lz+iDyvXO2O7ihwEJIdUtBg+cZZasIJVxtA=; b=yaQF4HUzED4ADWArYpBE5mK+PKUJTWLezryqEEBo3UDAA3FL8XZr2XJNEkd/+3c8Y8 68pDn0pOAAaFYVwtUnWmiX3p2TN+EesUVk3/PhLVysfdKaYMLtausOJv8d6kJPhooX02 B2OI8SYh1UVNMti0FXDRcl4HjCE/Dhy6we7qnR8gXnJcLrpgpAydZqz0QYS0XJI82Cpn ZT8PRHVJvIboqnPfs23LuPlIBtvYFgbdnag+8iHUcH7JeaMgbMovtyS4nLyGqYzw9bbm qIrMv+ah6wAkqdXECQ36NT6u9sNWkukvKpGLXNr7QJowEInrxUih6Az4rW/fwBQzhJIA A+oA== X-Received: by 10.68.97.225 with SMTP id ed1mr14667313pbb.153.1418288752023; Thu, 11 Dec 2014 01:05:52 -0800 (PST) Received: from raichu ([198.244.104.6]) by mx.google.com with ESMTPSA id e9sm732136pdp.59.2014.12.11.01.05.50 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Dec 2014 01:05:50 -0800 (PST) Sender: Mark Johnston Date: Thu, 11 Dec 2014 01:05:42 -0800 From: Mark Johnston To: "Andrey V. Elsukov" Subject: Re: svn commit: r275695 - head/sys/netinet6 Message-ID: <20141211090542.GA34208@raichu> References: <201412110041.sBB0ftwC030057@svn.freebsd.org> <5489597C.80707@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5489597C.80707@FreeBSD.org> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Dec 2014 09:05:52 -0000 On Thu, Dec 11, 2014 at 11:44:44AM +0300, Andrey V. Elsukov wrote: > On 11.12.2014 03:41, Mark Johnston wrote: > > Author: markj > > Date: Thu Dec 11 00:41:54 2014 > > New Revision: 275695 > > URL: https://svnweb.freebsd.org/changeset/base/275695 > > > > Log: > > Fix a bug in r266857: nd6_dad_find() must return NULL if it doesn't find > > a matching element in the DAD queue. > > If there was no matching element, TAILQ_FOREACH will stop the loop with > dp == NULL. If there is bug somewhere, it isn't here. You're right - sorry for the noise. :( I somehow managed to convince myself that TAILQ_FOREACH() wouldn't set dp to NULL at end of a non-empty list. I'll revert the change now.