From nobody Tue Aug 1 21:06:53 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RFnjb0L8Cz4prZD; Tue, 1 Aug 2023 21:06:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RFnjT5m6Kz3Lnd; Tue, 1 Aug 2023 21:06:53 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690924013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vbeeIFkn7LCva5Ckb5gru6QuCCcd3XowrYCXK9KIvr0=; b=QlzWXWsAdjurbuVwN2/4y26R8zwnTL0zhAshf4tJ8xpM1L9D52vYnoea+bytT7w31FfSr8 r6l+8YeFl3/IbAssx30f6T/pq3m4HGOV7Unv4Y+Ke7GxgJydsNcffBeCKTUHOhOy6oiELX HujKPZFPa1wd2T6jBtpFF5pY6EYJ9wE4gE9QaBXMOPcF+gXl9mZtSeURfzVjuVyJL5H+OP 5zPpHTnc8IONUxzaxnEKF8OrrXsP9ZrZO3ORa2W/dUoB8EMbEnpwcTgyAFzhBWFGOwEDor AEav5pA1O3WK5YuDzd098XKNmsvf4qtIt1qVpZFXgYLQc+ReAYg/7ssn70Agnw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1690924013; a=rsa-sha256; cv=none; b=J5yQkLQEKtUZdHHbx5mXK/AZ7tbDiwMRbzZzT16MU/mYdUZFNLH+w1Mk5KWYqvOdSShsRh Kls5I5aruWzrlWPRLhl1wJGbZa+sO5NiczKvIWOPNJJ9cVDUMexBn0SziItz7rEYhLL+3Z Y1zhjoAVSVOA8/GlVwrwwUmtFjYKkUjdg65h/pt755Di5MWddXZgUmIuBGx6bBxRe/6ZmU 1o9dJtby5v9M+W7tsdPOWpNfNatPe5vB0as44GY2wqfy4DnRvHl3yGBZtAo+p5oh3jp6iZ MPuWHOFsoJIlAX/FfsUrBsBUtfxnBx2+l4n8V7+bC0YrmGfn4+0FUomBWt1/kA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690924013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vbeeIFkn7LCva5Ckb5gru6QuCCcd3XowrYCXK9KIvr0=; b=rMfJqOaq8vKRiaDrXdonEI/h+iU+Szm9Zyq5xHtH50Di6tzZVjLC/B9xJXQ3b58BoBa+n0 nVJmQqT++2jVE1gEjfxuvgUwHhxKzxya7uxknrf+O9Fl/odQzKw5eQ0Wrda5X7XcYU2DDs bnp1DnRfNfkHPFdFQyC2jCj+pbYyzvV0dOH6oelVaNUXnLiGL+kF66G8H8UB5spucx9SOh oo5ISsyAmcGnu1MXEgiINW1Y7GGkdyT+jZf5W9NynszdOFUHK0vcj/hBCzPHCam5dsIFHl IM4L2tLrjMezOKCwi6G49KecLQYlp42HTcNbBE71iGTx/Oc/bxqOGcZMRSaHow== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RFnjT4Qt1zsgq; Tue, 1 Aug 2023 21:06:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 371L6rNp013948; Tue, 1 Aug 2023 21:06:53 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 371L6rka013946; Tue, 1 Aug 2023 21:06:53 GMT (envelope-from git) Date: Tue, 1 Aug 2023 21:06:53 GMT Message-Id: <202308012106.371L6rka013946@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Jessica Clarke Subject: git: a93799b55d2d - stable/13 - kmod.mk: Use portable printf '%s' over non-portable echo -n List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jrtc27 X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: a93799b55d2d2feb552c4b2af9318bacb13d8104 Auto-Submitted: auto-generated The branch stable/13 has been updated by jrtc27: URL: https://cgit.FreeBSD.org/src/commit/?id=a93799b55d2d2feb552c4b2af9318bacb13d8104 commit a93799b55d2d2feb552c4b2af9318bacb13d8104 Author: Jessica Clarke AuthorDate: 2023-07-11 20:30:06 +0000 Commit: Jessica Clarke CommitDate: 2023-08-01 20:42:53 +0000 kmod.mk: Use portable printf '%s' over non-portable echo -n Whilst /bin/echo on macOS and Linux implement -n, as do the builtin echos in bash and zsh, the builtin echo in dash does not, causing the first line of the output to be -n foo rather than just foo, and there to be an extra newline in the output and thus blank line, both of which result in "Symbol ... is not present in *.kld" warnings appearing in the build output (once for -n foo and once for the empty string for each module where EXPORT_SYMS is a list of symbols). MFC after: 1 week (cherry picked from commit d1e44bc94494448de196948d698b637b6e1df4bf) --- sys/conf/kmod.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/conf/kmod.mk b/sys/conf/kmod.mk index 4a0d828f0159..777bd91a313b 100644 --- a/sys/conf/kmod.mk +++ b/sys/conf/kmod.mk @@ -275,7 +275,7 @@ ${FULLPROG}: ${OBJS} .if ${EXPORT_SYMS} == NO :> export_syms .elif !exists(${.CURDIR}/${EXPORT_SYMS}) - echo -n "${EXPORT_SYMS:@s@$s${.newline}@}" > export_syms + printf '%s' "${EXPORT_SYMS:@s@$s${.newline}@}" > export_syms .else grep -v '^#' < ${EXPORT_SYMS} > export_syms .endif