Date: Fri, 22 Jun 2012 15:04:13 +0200 From: Alfred Bartsch <bartsch@dssgmbh.de> To: ports@freebsd.org Subject: inconsistent use of make variable SAMBA_PORT Message-ID: <4FE46D4D.4000208@dssgmbh.de>
next in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi all,
today I stumbled upon another small inconsistency in the portstree.
In our environment we will use samba-3.5. After adding
SAMBA_PORT=samba35 to /etc/make.conf, make index fails complaining
about missing ports directory "/usr/ports/samba35", which is obviously
true.
After some analyzing, I found that the make variable SAMBA_PORT is
used variously in the portstree:
Some ports (net-im/kpopup, net/lanbrowsing ...) seem to do it the
right way:
SAMBA_PORT?= net/samba34
Some other ports do not :
devel/p5-Parse-Pidl:
SAMBA_PORT?= samba4-devel
MASTERDIR= ${.CURDIR}/../../net/${SAMBA_PORT}
misc/amanda[|26|32]-server:
SAMBA_PORT?= samba34
BUILD_DEPENDS+= smbclient:${PORTSDIR}/net/${SAMBA_PORT}
RUN_DEPENDS+= smbclient:${PORTSDIR}/net/${SAMBA_PORT}
misc/amanda25-server seems to be correct.
net/samba-libsmbclient:
SAMBA_PORT= samba34
MASTERDIR= ${.CURDIR}/../${SAMBA_PORT}
this unconditional setting renders using another samba version
impossible, it should read "?=" instead of "=".
Can someone with commit bit on the list please see to it, or will it
be better to file a PR?
- --
Regards
Alfred Bartsch
Data-Service GmbH
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (FreeBSD)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk/kbU0ACgkQ5QGe2JdVf3idLwCgvvW4uoYrP38hp1/BaWsJ9LD2
oc0AoKWXJ4Lnx9NTmhgsn2SzWgXJ4HON
=s7b7
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4FE46D4D.4000208>