From owner-freebsd-ports@FreeBSD.ORG Fri Jun 22 13:04:17 2012 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8EF52106564A for ; Fri, 22 Jun 2012 13:04:17 +0000 (UTC) (envelope-from bartsch@dssgmbh.de) Received: from dss.incore.de (dss.incore.de [195.145.1.138]) by mx1.freebsd.org (Postfix) with ESMTP id 499188FC19 for ; Fri, 22 Jun 2012 13:04:17 +0000 (UTC) Received: from inetmail.dmz (inetmail.dmz [10.3.0.3]) by dss.incore.de (Postfix) with ESMTP id 794AC5C2F7 for ; Fri, 22 Jun 2012 15:04:16 +0200 (CEST) X-Virus-Scanned: amavisd-new at incore.de Received: from dss.incore.de ([10.3.0.3]) by inetmail.dmz (inetmail.dmz [10.3.0.3]) (amavisd-new, port 10024) with LMTP id a2cJJO_y3jEd for ; Fri, 22 Jun 2012 15:04:13 +0200 (CEST) Received: from mail.incore (fwintern.dmz [10.0.0.253]) by dss.incore.de (Postfix) with ESMTP id D0F335C35F for ; Fri, 22 Jun 2012 15:04:13 +0200 (CEST) Received: from pcadmin.incore (pcadmin.incore [192.168.0.140]) by mail.incore (Postfix) with ESMTPSA id C9FAB4508A for ; Fri, 22 Jun 2012 15:04:13 +0200 (CEST) Message-ID: <4FE46D4D.4000208@dssgmbh.de> Date: Fri, 22 Jun 2012 15:04:13 +0200 From: Alfred Bartsch User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:7.0.1) Gecko/20111007 Thunderbird/7.0.1 MIME-Version: 1.0 To: ports@freebsd.org X-Enigmail-Version: undefined Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Fri, 22 Jun 2012 16:35:38 +0000 Cc: Subject: inconsistent use of make variable SAMBA_PORT X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jun 2012 13:04:17 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi all, today I stumbled upon another small inconsistency in the portstree. In our environment we will use samba-3.5. After adding SAMBA_PORT=samba35 to /etc/make.conf, make index fails complaining about missing ports directory "/usr/ports/samba35", which is obviously true. After some analyzing, I found that the make variable SAMBA_PORT is used variously in the portstree: Some ports (net-im/kpopup, net/lanbrowsing ...) seem to do it the right way: SAMBA_PORT?= net/samba34 Some other ports do not : devel/p5-Parse-Pidl: SAMBA_PORT?= samba4-devel MASTERDIR= ${.CURDIR}/../../net/${SAMBA_PORT} misc/amanda[|26|32]-server: SAMBA_PORT?= samba34 BUILD_DEPENDS+= smbclient:${PORTSDIR}/net/${SAMBA_PORT} RUN_DEPENDS+= smbclient:${PORTSDIR}/net/${SAMBA_PORT} misc/amanda25-server seems to be correct. net/samba-libsmbclient: SAMBA_PORT= samba34 MASTERDIR= ${.CURDIR}/../${SAMBA_PORT} this unconditional setting renders using another samba version impossible, it should read "?=" instead of "=". Can someone with commit bit on the list please see to it, or will it be better to file a PR? - -- Regards Alfred Bartsch Data-Service GmbH -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk/kbU0ACgkQ5QGe2JdVf3idLwCgvvW4uoYrP38hp1/BaWsJ9LD2 oc0AoKWXJ4Lnx9NTmhgsn2SzWgXJ4HON =s7b7 -----END PGP SIGNATURE-----