From owner-freebsd-current@FreeBSD.ORG Thu Nov 8 17:48:04 2012 Return-Path: Delivered-To: current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9A3BA109 for ; Thu, 8 Nov 2012 17:48:04 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id E1CE78FC08 for ; Thu, 8 Nov 2012 17:48:03 +0000 (UTC) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id TAA19346 for ; Thu, 08 Nov 2012 19:48:02 +0200 (EET) (envelope-from avg@FreeBSD.org) Message-ID: <509BF051.7030707@FreeBSD.org> Date: Thu, 08 Nov 2012 19:48:01 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:16.0) Gecko/20121029 Thunderbird/16.0.2 MIME-Version: 1.0 To: current@FreeBSD.org Subject: Re: [head tinderbox] failure on amd64/amd64 References: <201211081731.qA8HVbrV092796__9933.24017986215$1352395930$gmane$org@freebsd-current.sentex.ca> In-Reply-To: <201211081731.qA8HVbrV092796__9933.24017986215$1352395930$gmane$org@freebsd-current.sentex.ca> X-Enigmail-Version: 1.4.5 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Nov 2012 17:48:04 -0000 on 08/11/2012 19:31 FreeBSD Tinderbox said the following: > cc -c -O2 -pipe -fno-strict-aliasing -std=c99 -Wall -Wredundant-decls > -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith > -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions > -Wmissing-include-dirs -fdiagnostics-show-option > -Wno-error-tautological-compare -Wno-error-empty-body > -Wno-error-parentheses-equality -nostdinc -I. -I/src/sys > -I/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include > opt_global.h -DGPROF -DGPROF4 -DGUPROF -fno-builtin -fno-omit-frame-pointer > -mno-aes -mno-avx -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float > -fno-asynchronous-unwind-tables -ffreestanding -fstack-protector -Werror -pg > /src/sys/dev/aac/aac_debug.c /src/sys/dev/aac/aac_debug.c:163:8: error: format > string is not a string literal (potentially insecure) > [-Werror,-Wformat-security] panic(reason); ^~~~~~ 1 error generated. *** > [aac_debug.o] Error code 1 I think that clang complaint is rightful here. But the tinderbox errors that we are getting after switch make me wonder if more preparations should have been done before the switch to make the transition smoother. -- Andriy Gapon