From owner-freebsd-rc@FreeBSD.ORG Thu Oct 23 13:33:40 2014 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CDFF1C1C for ; Thu, 23 Oct 2014 13:33:40 +0000 (UTC) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9F273794 for ; Thu, 23 Oct 2014 13:33:40 +0000 (UTC) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by gateway2.nyi.internal (Postfix) with ESMTP id 34896132B for ; Thu, 23 Oct 2014 09:33:33 -0400 (EDT) Received: from web3 ([10.202.2.213]) by compute5.internal (MEProxy); Thu, 23 Oct 2014 09:33:33 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=message-id:x-sasl-enc:from:to :mime-version:content-transfer-encoding:content-type:in-reply-to :references:subject:date; s=smtpout; bh=eTpV4LQ9112vYTQPoztHxwYn Jyg=; b=JzT5wBwHRcRfjcjiF5oRpH1exabGJenv96RkYNeR2+sBA/3rEz9J/S7b WZ2n2BXPHMj5nBeH51yRDXtzGDKuA6AFYeVZZLCIKHZt8RqZQQKgECCnfg2ZHRDZ X3lnzpukd3UhQrZPMfh5WRrXMM839Odm+QSFcgbS79RkmWqHwPA= Received: by web3.nyi.internal (Postfix, from userid 99) id C915A10D74D; Thu, 23 Oct 2014 09:33:32 -0400 (EDT) Message-Id: <1414071212.176533.182439477.59A47812@webmail.messagingengine.com> X-Sasl-Enc: fmfBzIg41R4rjmTjPHSDZXRbXTBrxA5Wn5SAjb+j/9U9 1414071212 From: Mark Felder To: freebsd-rc@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain X-Mailer: MessagingEngine.com Webmail Interface - ajax-c1967a3d In-Reply-To: <685F1351-19A9-47F8-8119-AD6FAE903B10@christianserving.org> References: <20141017.102259.2303779237508789020.hrs@allbsd.org> <685F1351-19A9-47F8-8119-AD6FAE903B10@christianserving.org> Subject: Re: [CFT] multiple instance support in rc.d script Date: Thu, 23 Oct 2014 08:33:32 -0500 X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Oct 2014 13:33:40 -0000 On Wed, Oct 22, 2014, at 12:02, Jim Riggs wrote: > On 16 Oct 2014, at 20:22, Hiroki Sato wrote: > > > I would like your feedback and testers of the attached patch. This > > implements multiple instance support in rc.d scripts. You can try it > > by replacing /etc/rc.subr with the attached one. > > > I really like the idea, as I have written at least 2 or 3 ports in which > I have needed support for multiple "profiles" (as I have seen them called > in several ports). So, I had to duplicate the multiple-instance logic in > the rc script for each. This would save all of that aggravation. > > The only concern I have with generalizing the approach in rc.subr, > though, is that not every app/daemon/script can or should support it. I > worry that some things if run multiple times may stomp on each other or > corrupt data or break something. It seems that there should be a way for > each rc script to either opt in or opt out of multiple instance support. > I don't know which is better. Opt-in is probably safer, but then core > devs and port maintainers have to make specific changes to support it. > :-\ > > Thoughts? > I would definitely prefer opt-in. We don't want to break things or lose users' data; POLA. After the feature is available users can request support if the maintainers aren't already working on it.