From owner-svn-src-all@FreeBSD.ORG Fri Jan 11 09:44:33 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id D2E153CB; Fri, 11 Jan 2013 09:44:33 +0000 (UTC) (envelope-from jh@FreeBSD.org) Received: from gw01.mail.saunalahti.fi (gw01.mail.saunalahti.fi [195.197.172.115]) by mx1.freebsd.org (Postfix) with ESMTP id 8DE23D67; Fri, 11 Jan 2013 09:44:33 +0000 (UTC) Received: from a91-153-116-96.elisa-laajakaista.fi (a91-153-116-96.elisa-laajakaista.fi [91.153.116.96]) by gw01.mail.saunalahti.fi (Postfix) with SMTP id 20967151738; Fri, 11 Jan 2013 11:44:14 +0200 (EET) Date: Fri, 11 Jan 2013 11:44:11 +0200 From: Jaakko Heinonen To: Warner Losh Subject: Re: svn commit: r244585 - in head: . sys/geom/label Message-ID: <20130111094410.GA1830@a91-153-116-96.elisa-laajakaista.fi> References: <201212221343.qBMDhCHa086834@svn.freebsd.org> <201301070927.07157.jhb@freebsd.org> <20130108193146.GA1815@a91-153-116-96.elisa-laajakaista.fi> <201301091417.37451.jhb@freebsd.org> <20130109234526.GL2561@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: src-committers@freebsd.org, pjd@freebsd.org, John Baldwin , svn-src-all@freebsd.org, svn-src-head@freebsd.org, Konstantin Belousov , imp@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2013 09:44:33 -0000 On 2013-01-09, Warner Losh wrote: > > I do not object, but IMHO having names with the spaces in /dev is weird > > and possibly problematic. I agree and my my preference was also to disallow spaces. However I expected that someone might complain. > > This was the reason of my initial request to > > disable spaces, together with the fact that it changes the devctl(4) > > protocol (there might be other /dev/devctl readers besides devd). > > I'm not sure that the protocol changes are quire right yet... Just for the record, usb(4) already uses quoted values for certain devctl variables. See usb_notify_addq() in sys/dev/usb/usb_device.c. -- Jaakko