From owner-cvs-ports@FreeBSD.ORG Sat Dec 12 05:58:15 2009 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A80FC1065672 for ; Sat, 12 Dec 2009 05:58:15 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 5139F8FC16 for ; Sat, 12 Dec 2009 05:58:15 +0000 (UTC) Received: (qmail 7579 invoked by uid 399); 12 Dec 2009 05:58:14 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 12 Dec 2009 05:58:14 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4B2330FB.70309@FreeBSD.org> Date: Fri, 11 Dec 2009 21:58:19 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Thunderbird 2.0.0.23 (X11/20091206) MIME-Version: 1.0 To: "Philip M. Gollucci" References: <200912100507.nBA577Q3033700@repoman.freebsd.org> In-Reply-To: <200912100507.nBA577Q3033700@repoman.freebsd.org> X-Enigmail-Version: 0.96.0 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, Glen Barber , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/mail/p5-qpsmtpd/files qpsmtpd.in X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Dec 2009 05:58:15 -0000 Philip M. Gollucci wrote: > pgollucci 2009-12-10 05:07:07 UTC > > FreeBSD ports repository > > Modified files: > mail/p5-qpsmtpd/files qpsmtpd.in > Log: > Apply the following fixes to the rc.d script > - contains a typo > - does not daemonize the process by default > - does not check if the process is currently running > - does not provide output to STDOUT on start-up, shutdown, or when errors are encountered > > PR: ports/141330 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=141330 > Submitted by: Glen Barber > > Revision Changes Path > 1.2 +23 -2 ports/mail/p5-qpsmtpd/files/qpsmtpd.in > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/mail/p5-qpsmtpd/files/qpsmtpd.in.diff?&r1=1.1&r2=1.2&f=h I was going to install this port and try to come up with something a little more constructive but it gave an odd dependency error so I wasn't able to do so: ERROR: the required Digest::SHA1 module is installed, but is not an up-to-date version. at lib/Mail/SpamAssassin/Util/DependencyInfo.pm line 294. In any case, the rc.d script for this port has a lot of issues. As far as I can see most of the script needlessly duplicates functionality that is already in rc.d. In start_precmd, rather than using echo/exit rc.d scripts should use the err() method. However most of what's in there could be avoided by simply setting default values after load_rc_config. The whole start_cmd could and probably should be eliminated. The default command line should be set with command_args. Likewise the stop_cmd is probably not necessary at all, you really want to set command_interpreter instead. Have a look at http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html and the pages that it references. If you have any questions, feel free to post on -ports or -rc, we'll be glad to help you. hth, Doug -- Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/