From owner-freebsd-current@freebsd.org Wed Sep 4 14:27:13 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E6823F32F6 for ; Wed, 4 Sep 2019 14:27:13 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 46NmNx4hhgz4Myw for ; Wed, 4 Sep 2019 14:27:13 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mailman.nyi.freebsd.org (Postfix) id A113BF32F5; Wed, 4 Sep 2019 14:27:13 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A0D62F32F4 for ; Wed, 4 Sep 2019 14:27:13 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46NmNw6GnLz4Myv; Wed, 4 Sep 2019 14:27:12 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pl1-x641.google.com with SMTP id gn20so9651286plb.2; Wed, 04 Sep 2019 07:27:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=/EDxag+jeJ5/ns2XqTafhZMw5aSBm3V7Jxikrpu3UDo=; b=FA5Uq8qc0BHJyPEITRGwb4/lakBBleZeAFHTGUFAJ3OUcONcxgb+TgggQctEB2il/+ Jcdf8AZVDBrDMRtyghYad1RRefaLt3LcODTzQdlP+BOt9e4Fi+p1zkGj4/CY5/yAD9FD r3oWedvw5/EA2gim2cFnxsjIF087RcUdOptF5PYx6cGhjn3eH1j4yYbE3gc3kdxgB6c/ XvGUNAD8cMSeBcWOwu3j/0zxtfzW/fg1vmLFLSEdEMZxuaga40k184aoA88BVGs+wEeh TBdVu87MmqIfYRef+iumEYSgJ3mfLISEtqZkIIFxPBq6x3w7Ah6kkrGJpvUG8Qnt+Qe9 fmFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=/EDxag+jeJ5/ns2XqTafhZMw5aSBm3V7Jxikrpu3UDo=; b=UeUf3Tt9Pzkjnf+Norv78uHztfPykb5sSAFyYjCIS8PR8nhgYIeQHtSRL/65mavxhl 2nvPhMy9tg+SDcUrwQ2s177okGAJnJjrJOziZrs39lzWim7ZiV8KbLkJfoqlYnDwrZLB yuVyuz7++kSuHT5opp588T+glBaUN0E+qvSaRiyD4oFMJ0wkKPpgKLDIYA6o1Qlsu0xQ 52WpJayu6whKXXw57oKYN9az62PRqGetk/gobtbTETO158HwYwRYy7LYJ4n1wjyVXn36 2T0aVabLereQvVhINQvsQFpO/8JKAyxfhal9n2SbHFVtGCW9Al3fGNrJuJWZYZFYw6jO ec3A== X-Gm-Message-State: APjAAAUl7ZypRU8Qyuy42N3j/yerYT3kmBfn9HHjzOv3XM+13hkIemPB gaIfmdt7ILk+HkYGiQmbO16wNv7/KQY= X-Google-Smtp-Source: APXvYqw88w61RwkUm50ElcQkCnxc+fB8nIy9gStlNALnXrH5cR/wBA7CcjDl6ED3ptIVfeA5vf+x9w== X-Received: by 2002:a17:902:9349:: with SMTP id g9mr40337162plp.262.1567607230830; Wed, 04 Sep 2019 07:27:10 -0700 (PDT) Received: from ?IPv6:2607:fb90:b21e:2263:4cd7:25c7:1dea:406e? ([2607:fb90:b21e:2263:4cd7:25c7:1dea:406e]) by smtp.gmail.com with ESMTPSA id q8sm2807397pjd.28.2019.09.04.07.27.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Sep 2019 07:27:10 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (1.0) Subject: Re: Weird goings on with make::empty() From: Enji Cooper X-Mailer: iPhone Mail (16G102) In-Reply-To: <3843.1567598344@critter.freebsd.dk> Date: Wed, 4 Sep 2019 07:27:09 -0700 Cc: current@freebsd.org, kevans@FreeBSD.org Content-Transfer-Encoding: quoted-printable Message-Id: <969A062A-A52A-49E3-B4E3-CC9377B08C80@gmail.com> References: <3843.1567598344@critter.freebsd.dk> To: Poul-Henning Kamp X-Rspamd-Queue-Id: 46NmNw6GnLz4Myv X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=FA5Uq8qc; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::641 as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com X-Spamd-Result: default: False [-3.48 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MV_CASE(0.50)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-0.99)[-0.986,0]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(0.00)[ip: (-0.48), ipnet: 2607:f8b0::/32(-2.76), asn: 15169(-2.28), country: US(-0.05)]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[1.4.6.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Sep 2019 14:27:14 -0000 > On Sep 4, 2019, at 04:59, Poul-Henning Kamp wrote: >=20 > On: >=20 > Repository Root: svn+ssh://repo.freebsd.org/base > Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > Revision: 351809 >=20 > I built a kernel, but drm-current-kmod did not get compiled > from the new world order in /usr/local/sys/modules >=20 > Debugging I ended up doing this to src/sys/conf/kern.post.mk: >=20 > Index: sys/conf/kern.post.mk > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- sys/conf/kern.post.mk (revision 351809) > +++ sys/conf/kern.post.mk (working copy) > @@ -77,12 +77,14 @@ > ${target:S/^reinstall$/install/:S/^clobber$/cleandir/} > .endif > .for module in ${LOCAL_MODULES} > -.if !empty(module) > + true "XXX A $(module) 2 ${LOCALBASE} 3 ${LOCAL_MODULES} 4 ${MODULE= S_WITH_WORLD}" > +#.if !empty(module) > + true "XXX B $(module) 2 ${LOCALBASE} 3 ${LOCAL_MODULES} 4 ${MODULE= S_WITH_WORLD}" > @${ECHODIR} "=3D=3D=3D> ${module} (${target:S/^reinstall$/install/:= S/^clobber$/cleandir/})" > @cd ${LOCAL_MODULES_DIR}/${module}; ${MKMODULESENV} ${MAKE} \ > DIRPRFX=3D"${module}/" \ > ${target:S/^reinstall$/install/:S/^clobber$/cleandir/} > -.endif > +#.endif > .endfor > .endif > .endfor >=20 > This gives me the expected output from buildkernel: >=20 > true "XXX A drm-current-kmod 2 /usr/local 3 drm-current-kmod 4 " > true "XXX B drm-current-kmod 2 /usr/local 3 drm-current-kmod 4 " >=20 > If I leave in the ".if !empty(module)" line in, I only get: >=20 > true "XXX A drm-current-kmod 2 /usr/local 3 drm-current-kmod 4 " >=20 > suggestions welcome... (CCing Kyle) This behavior change is probably caused by r351799. I personally think the code before Kyle=E2=80=99s change and after it was bu= ggy. It=E2=80=99s not word splitting LOCAL_MODULES before iterating over it.= Cheers, -Enji=