From owner-freebsd-ports  Wed Nov  1  6:57:38 2000
Delivered-To: freebsd-ports@freebsd.org
Received: from puck.firepipe.net (mcut-b-167.resnet.purdue.edu [128.211.209.167])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2E0E937B4C5; Wed,  1 Nov 2000 06:57:35 -0800 (PST)
Received: by puck.firepipe.net (Postfix, from userid 1000)
	id BE72219CD; Wed,  1 Nov 2000 09:57:34 -0500 (EST)
Date: Wed, 1 Nov 2000 09:57:34 -0500
From: Will Andrews <will@physics.purdue.edu>
To: Yarema <yds@dppl.com>
Cc: will@FreeBSD.org, freebsd-ports@FreeBSD.org,
	"David W. Chapman Jr." <dwcjr@inethouston.net>,
	Terje Elde <terje@thinksec.com>
Subject: Re: ports/21439: FIX: mail/postfix-current
Message-ID: <20001101095734.I36336@puck.firepipe.net>
Reply-To: Will Andrews <will@physics.purdue.edu>
References: <200011010454.UAA20099@freefall.freebsd.org> <3A0022F0.435686CD@dppl.com> <3A00299E.16D3F54D@dppl.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <3A00299E.16D3F54D@dppl.com>; from yds@dppl.com on Wed, Nov 01, 2000 at 09:33:02AM -0500
X-Operating-System: FreeBSD 4.1-STABLE i386
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

On Wed, Nov 01, 2000 at 09:33:02AM -0500, Yarema wrote:
> Oops.  Just realized I sent the wrong diff.  The one I ment to send and
> described above is attached to this message.
> 
> Also another part missing in the current port is the following line in
> PLIST:
> 
> @unexec rm -rf /var/spool/postfix

This is not acceptable.  The port cannot touch directories like this..
what if somebody's just deinstalling mail/postfix-current to upgrade to
a new version?  Say goodbye to /var/spool/postfix with 30,000 email
messages in the queue?

> I can also see a number of reasons for omitting this line since there
> may be undelivered mail sitting in the spool.  Perhaps a message
> indicating the directory should be removed manually would be more
> apropos.

Ooops.. I wrote the above before reading this.. yes, this is  why I
removed it.

> -- 
> Yarema
> diff -ruN postfix-current.orig/Makefile postfix-current/Makefile
> --- postfix-current.orig/Makefile	Wed Nov  1 02:37:39 2000
> +++ postfix-current/Makefile	Wed Nov  1 08:50:03 2000
> @@ -99,7 +99,10 @@
>  	${ECHO} "all: default" >> Makefile)
>  
>  pre-install:
> -	${SH} ${PKGINSTALL} Postfix PRE-INSTALL
> +	@PKG_PREFIX=${PREFIX} ${SH} ${PKGINSTALL} ${PKGNAME} PRE-INSTALL
> +
> +post-install:
> +	@PKG_PREFIX=${PREFIX} ${SH} ${PKGINSTALL} ${PKGNAME} POST-INSTALL
>  
>  do-install:
>  	@${INSTALL} -d -o ${BINOWN} -g ${BINGRP} -m 0755 \
> @@ -163,10 +166,10 @@
>  	@${MKDIR} -m 755 /var/spool/postfix
>  	@${CHOWN} root:wheel /var/spool/postfix
>  
> -	@${ECHO_MSG} "--------------------------------------------------"
> -	@${ECHO_MSG} "- To replace your existing sendmail with postfix -"
> -	@${ECHO_MSG} "- type \"make replace\"                          -"
> -	@${ECHO_MSG} "--------------------------------------------------"
> +	@${ECHO_MSG} '--------------------------------------------------'
> +	@${ECHO_MSG} '- To replace your existing sendmail with postfix -'
> +	@${ECHO_MSG} '- type "make replace"                            -'
> +	@${ECHO_MSG} '--------------------------------------------------'
>  
>  .include <bsd.port.pre.mk>

Cool.

-- 
wca


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message