From owner-cvs-src@FreeBSD.ORG  Fri Apr 25 13:05:31 2008
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4F2DC106568B;
	Fri, 25 Apr 2008 13:05:31 +0000 (UTC)
	(envelope-from rdivacky@vlk.vlakno.cz)
Received: from vlakno.cz (vlk.vlakno.cz [62.168.28.247])
	by mx1.freebsd.org (Postfix) with ESMTP id DFBB28FC23;
	Fri, 25 Apr 2008 13:05:30 +0000 (UTC)
	(envelope-from rdivacky@vlk.vlakno.cz)
Received: from localhost (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id CAFBC67B1A4;
	Fri, 25 Apr 2008 15:05:04 +0200 (CEST)
X-Virus-Scanned: amavisd-new at vlakno.cz
Received: from vlakno.cz ([127.0.0.1])
	by localhost (vlk.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id OAnkZljtwPqZ; Fri, 25 Apr 2008 15:05:00 +0200 (CEST)
Received: from vlk.vlakno.cz (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id ECE1967AFCC;
	Fri, 25 Apr 2008 15:04:59 +0200 (CEST)
Received: (from rdivacky@localhost)
	by vlk.vlakno.cz (8.14.2/8.14.2/Submit) id m3PD4x7F070145;
	Fri, 25 Apr 2008 15:04:59 +0200 (CEST) (envelope-from rdivacky)
Date: Fri, 25 Apr 2008 15:04:59 +0200
From: Roman Divacky <rdivacky@FreeBSD.org>
To: Kris Kennaway <kris@FreeBSD.org>
Message-ID: <20080425130459.GA70110@freebsd.org>
References: <200804242208.m3OM8a12040177@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200804242208.m3OM8a12040177@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.3i
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern kern_descrip.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 25 Apr 2008 13:05:31 -0000

On Thu, Apr 24, 2008 at 10:08:36PM +0000, Kris Kennaway wrote:
> kris        2008-04-24 22:08:36 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/kern             kern_descrip.c 
>   Log:
>   fdhold can return NULL, so add the one remaining missing check for this
>   condition.

        fdp = fdhold(p);
+       if (fdp == NULL)
+               return (0);
        PROC_UNLOCK(p);

I think you leak the PROC lock here...