From owner-freebsd-embedded@FreeBSD.ORG Sat Mar 13 13:05:33 2010 Return-Path: Delivered-To: embedded@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 236611065670 for ; Sat, 13 Mar 2010 13:05:33 +0000 (UTC) (envelope-from loos.br@gmail.com) Received: from mail-gy0-f182.google.com (mail-gy0-f182.google.com [209.85.160.182]) by mx1.freebsd.org (Postfix) with ESMTP id CF49C8FC1E for ; Sat, 13 Mar 2010 13:05:32 +0000 (UTC) Received: by gyf2 with SMTP id 2so912550gyf.13 for ; Sat, 13 Mar 2010 05:05:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:mime-version :content-type:from:in-reply-to:date:cc:content-transfer-encoding :message-id:references:to:x-mailer; bh=Mdoq2NwhNoV4TtD343MaLuZHmBBFT5LT+Ty96SMDIsA=; b=PqgYCpKoJu0co5fbV8niAT4pYN6TO1caQ+Rp4HdK0oSf5D3OsJqrbWExA4sWvfyrtG DE2VKXC4G8ZcwCPAUVvqBN4POS5VLrpDpT1oR8vETQzBRJSBRxBD1YVagxEoy6TtlPAP gOEnrEv/ACH7Y0CfqzpaGfz5T8XlrV+dJmKqo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer; b=VgvHt1mlniyCEP4KDiD88UWLqbqy85X/xrT77v+Wh8Y116LsQMaYADg4MDZwZ8neX0 UDGT57idQ6kUmpDgVKkFFwriTvdr3pcYw1xKTNDLnXwrsfaMaOgzDqk/aTM4FAVraTgf aNtaWoANO0pEX9RRg4FDAuE3V6wPijQteBlvI= Received: by 10.150.1.4 with SMTP id 4mr1309822yba.317.1268484111766; Sat, 13 Mar 2010 04:41:51 -0800 (PST) Received: from [192.168.0.86] ([187.39.15.241]) by mx.google.com with ESMTPS id 5sm122367yxd.17.2010.03.13.04.41.49 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 13 Mar 2010 04:41:50 -0800 (PST) Mime-Version: 1.0 (Apple Message framework v1077) Content-Type: text/plain; charset=us-ascii From: Luiz Otavio O Souza In-Reply-To: <20100312220205.2fbc8ab7@fubar.geek.nz> Date: Sat, 13 Mar 2010 09:41:47 -0300 Content-Transfer-Encoding: quoted-printable Message-Id: References: <0AE04EFA-A3EB-4939-BD81-607C00355B67@semihalf.com> <20100312220205.2fbc8ab7@fubar.geek.nz> To: Andrew Turner X-Mailer: Apple Mail (2.1077) Cc: embedded@freebsd.org, Grzegorz Bernacki Subject: Re: NAND Flash Framework for review X-BeenThere: freebsd-embedded@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Dedicated and Embedded Systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Mar 2010 13:05:33 -0000 On Mar 12, 2010, at 10:02 AM, Andrew Turner wrote: > On Tue, 9 Mar 2010 00:28:53 +0100 > Rafal Jaworowski wrote: >> We are looking for review, comments and any other feedback. >=20 > I've been reviewing the driver and should have some notes in the next > couple of days on areas I would like to see changes. >=20 > Andrew Rafal, first of all, i'd like to thank you, semihalf and Grzegorz for = the contribution, the code is very well written, clear and easy to = understand. That said, the code isn't ready to use, there are a few small things to = fix (ecc byte positions, bad block table for non onfi compliant devices, = there is no support to read status from ready/busy nand pin and gnand = interface doesn't work with disk->d_maxsize =3D=3D disk->d_sectorsize =3D=3D= device->blocksize). I've tested the code with two Hynix devices, one small page type = (512/16) with 64MB of capacity and the other is a large page type = (2048/64) with 512MB. The small page device works really fine, i can read the raw data and = verify ecc (the device has a YAFFS1 file system). Now i'm looking at ecc positions for the large page device which looks = like have a YAFFS2 FS on it, no luck with ecc data but raw data looks = fine. I'll wait for Andrew notes and then i gonna put some more ideas and = patches together. Luiz