From owner-freebsd-arch@FreeBSD.ORG Thu Sep 25 16:31:05 2014 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2B79F9B7 for ; Thu, 25 Sep 2014 16:31:05 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E505DB17 for ; Thu, 25 Sep 2014 16:31:04 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.9/8.14.9) with ESMTP id s8PGV4HI008146 for ; Thu, 25 Sep 2014 16:31:04 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.9/8.14.9/Submit) id s8PGV4Dc008145 for freebsd-arch@freebsd.org; Thu, 25 Sep 2014 16:31:04 GMT (envelope-from bdrewery) Received: (qmail 37536 invoked from network); 25 Sep 2014 11:30:59 -0500 Received: from unknown (HELO ?10.10.0.24?) (freebsd@shatow.net@10.10.0.24) by sweb.xzibition.com with ESMTPA; 25 Sep 2014 11:30:59 -0500 Message-ID: <5424433A.20809@FreeBSD.org> Date: Thu, 25 Sep 2014 11:30:50 -0500 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Adrian Chadd Subject: Re: KASSERT_WARN for asserting malloc(M_WAITOK) not in a non-sleepable thread References: <54236CD6.4050807@FreeBSD.org> <5424392D.9030201@FreeBSD.org> In-Reply-To: OpenPGP: id=6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="V60Dxl31Sv7EgWsAKel1WTptM704eex7J" Cc: "freebsd-arch@freebsd.org" X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Sep 2014 16:31:05 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --V60Dxl31Sv7EgWsAKel1WTptM704eex7J Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 9/25/2014 11:14 AM, Adrian Chadd wrote: > Hi, >=20 > Please bring in KASSERT_WARN(). >=20 > I'm grown up enough to use KASSERT_WARN() along with handling the > invariant check myself in code. Having KASSERT_WARN() means I can add > in this rather than printf()s or device_printf()'s with various knobs > to remove it. >=20 > (This is absolutely _not_ the "should KASSERT() optionally just log" > argument. I'm not going to get into that a second time.) Agreed on this 2nd point. I am against that. Plus we already have debug.kassert.log_panic_at to effectively do that. >=20 >=20 > -a >=20 >=20 --=20 Regards, Bryan Drewery --V60Dxl31Sv7EgWsAKel1WTptM704eex7J Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) iQEcBAEBAgAGBQJUJEM6AAoJEDXXcbtuRpfPA64H/0nIdIOMWU/sXHg8W2yW/nXQ mzf/odn6i4a+nXrevhAFwZsgmSQ0lEBF8UIq1hMSCnjuqz8Lsg8htF8ixfO5sqHn oGPKZPPq9c2SIt4VgeULLZ8RDlsujq6L2HehilFefuHuzgDV9Qf45bBgSSpBnZlS 82bL8qofK7B4gkvR+gHJa7I3iNO1jFiEcuRt29q4u7hL1sIg8XHWCgz4RlrtMskc HMxxxAuPrwtN27U8TQI3KKB1SIyNvD66/gH+Qzix/gwOfvhX3rrIQ+J5s6mfJIlS 7UVM5+6cCBtSBVaZupWKuVY7ToHXYx9dtrXQ9pE6vo3CDZKtmEUQdDrINIBOFdM= =Y0sM -----END PGP SIGNATURE----- --V60Dxl31Sv7EgWsAKel1WTptM704eex7J--